Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form Fixes #69

Merged
merged 15 commits into from
Feb 21, 2017
Merged

Form Fixes #69

merged 15 commits into from
Feb 21, 2017

Conversation

asabhaney
Copy link
Member

@asabhaney asabhaney commented Feb 20, 2017

Completed

  • Ensure form components work regardless of uglify options (convert form components to stateful components to ensure they are not read-only)
  • Ensure all form components can be used standalone (without Form or groups)
  • Handle componentWillReceiveProps correctly for all form components
  • Updated styling of checkbox and radio
  • Remove invalid event persistence (see: https://facebook.github.io/react/docs/events.html#event-pooling)

Future PR

  • Ensure form components work regardless of mangle options (see problem here)
  • Ensure values are always correct
  • Clean up and simplify Form component logic (deprecate recursive tree traversal)
  • Ensure form data serializes correctly on submit

@asabhaney asabhaney added this to the 1.6.0 milestone Feb 20, 2017
Copy link
Contributor

@stevenyuen stevenyuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I've also tested with Communities as well.

@asabhaney asabhaney merged commit 3db036e into 1.6.0 Feb 21, 2017
@asabhaney asabhaney deleted the form-fixes branch February 21, 2017 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants