Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplified Form Logic #73

Closed
wants to merge 23 commits into from
Closed

Simplified Form Logic #73

wants to merge 23 commits into from

Conversation

asabhaney
Copy link
Member

@asabhaney asabhaney commented Feb 25, 2017 •
edited by jaredreich
Loading

General:

  • Handle prop changes (used outside of Form)
  • Parse files from form (FormData)
  • Optimize re-renders
  • Add demo for custom form field (eg. date)
  • Update docs
  • Cleanup code
  • Ensure defaultValue and validation is working for all the components
  • Ensure updating is working for all components

Components:

  • Checkbox
  • CheckboxGroup
  • FileInput
  • ImageInput
  • Input
  • Radio
  • RadioGroup
  • Select
  • Switch
  • Textarea

@asabhaney asabhaney added this to the 1.6.0 milestone Feb 25, 2017
@asabhaney asabhaney mentioned this pull request Feb 27, 2017
Closed
jaredreich
jaredreich reviewed Feb 27, 2017
View reviewed changes
src/components/Form/Input/index.js Outdated
this.setState({ error })
} else {
this.setState({ error: undefined })
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this can simply be written as this.setState({ error })

jaredreich
jaredreich reviewed Feb 27, 2017
View reviewed changes
Copy link
Contributor

@jaredreich jaredreich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great. I'll take this from here!

@jaredreich jaredreich removed the request for review from stevenyuen March 2, 2017 18:06
@jaredreich
Copy link
Contributor

Closing in favour of #76

@jaredreich jaredreich closed this Mar 2, 2017
@jaredreich jaredreich deleted the form-fun branch March 2, 2017 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredreich jaredreich jaredreich left review comments

Assignees
No one assigned
Labels
in progress
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@asabhaney @jaredreich