remove c-style (incorrect) switch handling #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! Can this be covered with some tests just to make sure it will not be broken in the futere? |
Codecov Report
@@ Coverage Diff @@
## master #433 +/- ##
=======================================
Coverage 45.14% 45.14%
=======================================
Files 77 77
Lines 2700 2700
=======================================
Hits 1219 1219
Misses 1402 1402
Partials 79 79 Continue to review full report at Codecov.
|
vgarvardt
force-pushed
the
patch/remove-c-style-swtiches
branch
from
058dc1d
to
4c558d8
Compare
|
👍
|
vgarvardt
approved these changes
Aug 13, 2020
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We have some c-style code in go.
This PR cleans up that.