Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EES-3759 Updated redis and limiter libraries #458

Merged
merged 1 commit into from
Sep 3, 2020

Conversation

vgarvardt
Copy link
Contributor

@vgarvardt vgarvardt commented Sep 2, 2020

Current deps are very outdated, update some one-by-one. In this case redis and limiter updated at once because one depends on another.

@vgarvardt vgarvardt requested a review from a team September 2, 2020 14:00
@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #458 into master will not change coverage.
The diff coverage is 81.81%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #458   +/-   ##
=======================================
  Coverage   45.21%   45.21%           
=======================================
  Files          77       77           
  Lines        2696     2696           
=======================================
  Hits         1219     1219           
- Misses       1398     1399    +1     
+ Partials       79       78    -1     
Impacted Files Coverage Δ
pkg/plugin/oauth2/loader.go 0.00% <ø> (ø)
pkg/plugin/rate/rate_limit_logger.go 56.00% <77.77%> (ø)
pkg/plugin/rate/setup.go 51.92% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44603b8...49b13b4. Read the comment docs.

@aleksandrzhiliaev
Copy link
Contributor

aleksandrzhiliaev commented Sep 3, 2020

+1

Approved with Zappr Approved with Zappr Approved with Zappr Approved with Zappr

@vgarvardt vgarvardt merged commit 46cd6d7 into master Sep 3, 2020
@vgarvardt vgarvardt deleted the patch/update-limiter branch September 3, 2020 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants