feat: [HL-92] Login <> Handle and integrate login use case 🍕 #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add mock Data for LoginUseCase until Actual Request is finished
ahmdmhasn
reviewed
Jul 26, 2023
Domain/.gitignore
Outdated
There was a problem hiding this comment.
To be removed. Let's depend on the root .gitignore
Domain/README.md
Outdated
| @@ -0,0 +1,3 @@ | |||
| # Domain | |||
|
|
|||
| A description of this package. | |||
There was a problem hiding this comment.
Suggested change
| A description of this package. | |
| The Domain Layer is a crucial component of a software architecture that represents the core business logic and rules of the application. It acts as the heart of the system, encapsulating all the domain-specific logic and entities. |
| @@ -0,0 +1,4 @@ | |||
| @available(iOS 13.0.0, *) | |||
There was a problem hiding this comment.
Let's make the package support iOS 13 by default.
Healthy/AppCoordinator.swift
Outdated
There was a problem hiding this comment.
Why did you move the AppCoordinator & AppDelegate outside classes?
There was a problem hiding this comment.
It was By Mistake trying to sort them by name
| @@ -35,7 +35,6 @@ final class LoginViewController: UIViewController { | |||
|
|
|||
| override func viewDidLoad() { | |||
| super.viewDidLoad() | |||
|
|
|||
| configureAppearance() | |||
There was a problem hiding this comment.
Suggested change
| configureAppearance() | |
| configureAppearance() |
I prefer keeping a line between view did load and configuration logic.
Comment on lines
125
to
131
| .sink { error in | ||
| let alertController = UIAlertController( | ||
| title: "Error!!", | ||
| message: error.localizedDescription, | ||
| preferredStyle: .alert) | ||
|
|
||
| self.present(alertController, animated: true) |
There was a problem hiding this comment.
Suggested change
| .sink { error in | |
| let alertController = UIAlertController( | |
| title: "Error!!", | |
| message: error.localizedDescription, | |
| preferredStyle: .alert) | |
| self.present(alertController, animated: true) | |
| .sink { [weak self] error in | |
| let alertController = UIAlertController( | |
| title: "Error!!", | |
| message: error.localizedDescription, | |
| preferredStyle: .alert) | |
| self?.present(alertController, animated: true) |
Retain cycle.
ahmdmhasn
approved these changes
Jul 26, 2023
abdallah-7698
approved these changes
Jul 26, 2023
…tegrate-login-use-case # Conflicts: # Healthy.xcodeproj/project.pbxproj # Networking/Tests/NetworkingTests/Requests/MealCategoriesRequestTests.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add mock Data for LoginUseCase until Actual Request is finished
Proposed Changes
Related Issues
#97
Additional Information
https://motoon-eg.atlassian.net/jira/software/projects/HL/boards/2?selectedIssue=HL-92
Screenshot
N/A
Checklist