feat: [HL-21] Create Login view + layout ✨ #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhmdatallaa
changed the title
Ahattalla
reviewed
May 25, 2023
mhmdatallaa
force-pushed
the
feat/create-login-viewController
branch
from
fb8a761
to
a2ef3c1
Compare
Ahattalla
approved these changes
May 25, 2023
ahmdyasser
requested changes
May 25, 2023
ahmdmhasn
approved these changes
May 25, 2023
| @@ -0,0 +1,217 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
I favor using stack views over fully-constrained views. Let's discuss this if needed.
There was a problem hiding this comment.
I configured it at first using Stack views, but i couldn't satisfy figma's design layout.
Co-authored-by: Ahmed M. Hassan <45182214+ahmdmhasn@users.noreply.github.com>
ahmdyasser
approved these changes
May 25, 2023
abdelhamid-f-nasser
added a commit
that referenced
this pull request
May 26, 2023
…hub.com/motoon-eg/healthy into feat/HL-23-Create-account-screen-layout * 'feat/HL-23-Create-account-screen-layout' of https://github.com/motoon-eg/healthy: feat: [HL-21] Create Login view + layout ✨ (#23) feat: [HL-5] Update button styles (#20)
abdelhamid-f-nasser
added a commit
that referenced
this pull request
May 27, 2023
…evelop * 'develop' of https://github.com/motoon-eg/healthy: feat: [HL-21] Create Login view + layout ✨ (#23) feat: [HL-5] Update button styles (#20) feat: [HL-1] Configure Generating Localizable Strings (#16) feat: [HL-4] Update label styles 🎯 (#17) ci: [MAGIC] Apply GitHub workflow for pull requests (#21) fix : Resolve warning for run script build phase (#18) feat: [HL-4] Add UI label styling 🎯 (#8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Creating Login Screen.
Changes made: