Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructuring for faster build times #33

Merged
merged 19 commits into from
Jun 16, 2023

Conversation

scottenglert
Copy link
Collaborator

I was getting increasing build times as I was adding more classes. I read the pybind11 faq about breaking up the bindings into multiple translation units. So we now still get the same result but now we can use more processors to compile and speeds up rebuilding while developing. Also we can make slightly more organized folders as the number of classes increases.

Welcome to other ideas, but I get the same results as before but build times are much faster.

@mottosso
Copy link
Owner

Great, I've been wanting to do this as well due to build times. About the .inl filenames, it may be safe to rename these to .h now? I used .inl as they were initially just ways to split up one big .cpp file and .inl seems like the convention for that. But .h would be a more familiar convention for traditional header files, which these now look like.

@scottenglert
Copy link
Collaborator Author

Yeah that sounds good, I was debating changing it too, so I will do that next.

Starting to implement MFnMesh, added MObjectHand and a few other additions.
@mottosso
Copy link
Owner

Looks like the mac builds have broken, and that stubs generation too. That's the problem with relying on auto-updating third party services..

We should merge this though, so that we can keep making new commits. Anything you can do about the stubs breaking? Looks like it's related to this latest commit.

@scottenglert
Copy link
Collaborator Author

Yeah I think I know why the stubs failed. I didn't have a binding of another class I believe. I'm fixing that now. I am also updating things to build for 2024. I'll merge on my next push.

@scottenglert
Copy link
Collaborator Author

Hmm so I have to look into why the Mac build for 2024 is failing, if the dev kit is corrupt or a change in something with the unpacking tool.

The other issue is a problem with nose and Python 3.10. see this: nose-devs/nose#1122

@scottenglert
Copy link
Collaborator Author

I'm so close, I am still getting stuck with the mac build for some reason in 2024 and Mac OS 12. Everything is basically the same. Ideas?

@scottenglert
Copy link
Collaborator Author

Finally! It was something in cmake that xcode didn't like having a byproduct of the same file on two targets..... well we are good (for now). Merging!

@scottenglert scottenglert merged commit 4c7f99e into mottosso:master Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants