Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Change go get to go install in README #671

Merged
merged 1 commit into from
Oct 2, 2023
Merged

feat: Change go get to go install in README #671

merged 1 commit into from
Oct 2, 2023

Conversation

kavfixnel
Copy link
Contributor

@kavfixnel kavfixnel commented Jul 25, 2023

go get is no longer a valid command outside of the module:

~ ❯ go get -u moul.io/assh/v2
go: go.mod file not found in current directory or any parent directory.
	'go get' is no longer supported outside a module.
	To build and install a command, use 'go install' with a version,
	like 'go install example.com/cmd@latest'
	For more information, see https://golang.org/doc/go-get-install-deprecation
	or run 'go help get' or 'go help install'.

Instead, we should be using go install (See https://go.dev/doc/go-get-install-deprecation). Reflect this in the README

@kavfixnel kavfixnel requested a review from moul as a code owner July 25, 2023 05:51
@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Jul 25, 2023
@kavfixnel
Copy link
Contributor Author

I just noticed that there is also a tested with Go1.7 or above note right below this, that will likely be incorrect with this new command. Is go 1.7+ support very important, or can we assume that most people will have go 1.17+?

@moul
Copy link
Owner

moul commented Oct 2, 2023

We can definitely move to go1.17+ 👍.

@moul moul merged commit 869f978 into moul:master Oct 2, 2023
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Oct 2, 2023
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

🎉 This PR is included in version 2.16.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants