Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: small fixes #531

Merged
merged 14 commits into from
Jul 23, 2022
Merged

chore: small fixes #531

merged 14 commits into from
Jul 23, 2022

Conversation

moul
Copy link
Owner

@moul moul commented Jul 23, 2022

Addresses #532
Blocks #530
Blocks #528

┆Issue is synchronized with this Trello card

Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul moul self-assigned this Jul 23, 2022
@auto-add-label auto-add-label bot added the chore label Jul 23, 2022
@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Jul 23, 2022
@moul moul mentioned this pull request Jul 23, 2022
2 tasks
moul added 2 commits July 23, 2022 07:43
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul moul marked this pull request as ready for review July 23, 2022 07:45
moul added 8 commits July 23, 2022 07:47
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jul 23, 2022

Codecov Report

Merging #531 (c5f4c7a) into master (f352cb9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #531   +/-   ##
=======================================
  Coverage   27.95%   27.95%           
=======================================
  Files           6        6           
  Lines         440      440           
=======================================
  Hits          123      123           
  Misses        315      315           
  Partials        2        2           
Flag Coverage Δ
unittests 27.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/dvcore/run.go 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
moul added 2 commits July 23, 2022 18:56
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul moul merged commit 3d336c3 into master Jul 23, 2022
@moul moul deleted the dev/moul/small-fixes branch July 23, 2022 21:41
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Jul 23, 2022
@github-actions
Copy link

🎉 This PR is included in version 3.12.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore ✨ Merged Pull Request has been merged successfully released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant