Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: symlinks were not working as expected #30

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Conversation

moul
Copy link
Owner

@moul moul commented Nov 30, 2020

h/t @smowton

@auto-add-label auto-add-label bot added the bug Something isn't working label Nov 30, 2020
@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Nov 30, 2020
@codecov
Copy link

codecov bot commented Nov 30, 2020

Codecov Report

Merging #30 (a7bb0d3) into master (a1b8595) will increase coverage by 3.00%.
The diff coverage is 65.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
+ Coverage   67.76%   70.76%   +3.00%     
==========================================
  Files          11       11              
  Lines         242      260      +18     
==========================================
+ Hits          164      184      +20     
+ Misses         50       47       -3     
- Partials       28       29       +1     
Flag Coverage Δ
unittests 70.76% <65.38%> (+3.00%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
archive.go 57.97% <65.38%> (+18.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1b8595...a7bb0d3. Read the comment docs.

h/t @smowton

Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Nov 30, 2020

Expected release notes (by @moul-bot)

fixes:
symlinks were not working as expected (a7bb0d3)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@moul moul merged commit 909480a into master Nov 30, 2020
@moul moul deleted the dev/moul/fix-zip branch November 30, 2020 23:53
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Nov 30, 2020
@github-actions
Copy link

🎉 This PR is included in version 1.19.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ✨ Merged Pull Request has been merged successfully released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant