Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/oz defender platform #38

Merged
merged 14 commits into from
Aug 26, 2023
Merged

Chore/oz defender platform #38

merged 14 commits into from
Aug 26, 2023

Conversation

mattiascaricato
Copy link
Member

@mattiascaricato mattiascaricato commented Aug 15, 2023

Scope

  • Add OZ Defender as deployer
  • Pass admin as initializer argument instead of message sender

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (920d520) 100.00% compared to head (24294ae) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #38   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          168       167    -1     
  Branches        29        29           
=========================================
- Hits           168       167    -1     
Files Changed Coverage Δ
contracts/USDM.sol 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@openzeppelin-code
Copy link

openzeppelin-code bot commented Aug 15, 2023

Chore/oz defender platform

Generated at commit: 24294aecd21b31d240a76e98059817b501748295

🚨 Vulnerabilities Summary

Process Issues Results
Contract Inspector note
low
Total
8
1
9
Dependency Checker Total 0

For more details view the full report in OpenZeppelin Code

@ggonzalez94
Copy link

LGTM! My only question is why you had to add the defender-relay-client?

@mattiascaricato mattiascaricato changed the title Chore/oz platform Chore/oz defender platform Aug 24, 2023
@mattiascaricato mattiascaricato requested review from ggonzalez94 and removed request for ggonzalez94 August 25, 2023 22:07
@mattiascaricato mattiascaricato merged commit 2f0e2f0 into main Aug 26, 2023
9 checks passed
@mattiascaricato mattiascaricato deleted the chore/oz-platform branch August 26, 2023 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants