Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth adapter should prioritize pulling header values from params #49

Closed
coleshaw opened this issue May 26, 2020 · 0 comments · Fixed by #50
Closed

Auth adapter should prioritize pulling header values from params #49

coleshaw opened this issue May 26, 2020 · 0 comments · Fixed by #50
Assignees
@coleshaw

Comments

@coleshaw
Copy link
Collaborator

The auth adapter should, in approve_hmac, prefer header values from the body instead of the query params, since sometimes the query params might get mungled.
@coleshaw coleshaw self-assigned this May 26, 2020
@coleshaw coleshaw mentioned this issue May 26, 2020
Merged
corps added a commit that referenced this issue Aug 22, 2020
@corps
Zc/docker build improvements (#49)
ab8cd32 
docker build improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coleshaw coleshaw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue48 49 fix hmac signing mountetna/etna
1 participant
@coleshaw