Graft route names #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…more sensible order for success() helper
…t multiple hmac ids with separate keys
|
Merge this to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small one I've been meaning to write:
I added some specs to test the basic etna server functionality
Added some route parsing, so routes may contain parameters which get pulled into @params for use by the controller - this mostly gets used by Timur at this point (e.g. get '/:project_name'), so this is in anticipation of replacing Rails with Etna::Server.
A few bug fixes to allow block controllers (e.g. get '/some-route' { [ 200, {}, 'ok' ] }) to work and access @params