Graft fix hmac #23
Merged
Graft fix hmac #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l needs the request)
|
Looks good. Please merge. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a bunch of etna bug-fixes in here that I collected while working on metis. Notably:
The hmac auth should come before the user_auth check, otherwise if you have a token and request an hmac-signed url the token will get you past Etna::Auth, while the endpoint will expect you to have cleared via hmac.
ParseBody used to only check one type of input - now it parses the body into params based on content-type, but always also parses URL params
TestAuth should use the "Etna " for checking the token rather than "Basic "
The Route previously generated a route_path which was actually a full URL - now there is a route_url and route_path - also route params are substituted more better when forming a url
The sign service supports generating a random uid.