Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graft add error logging #30

Merged
merged 3 commits into from
Dec 4, 2018
Merged

Graft add error logging #30

merged 3 commits into from
Dec 4, 2018

Conversation

graft
Copy link
Contributor

@graft graft commented Nov 28, 2018

This PR updates the way etna applications log errors. Specifically it:

  • Creates a unique request_id to identify log lines by request
  • Defines a new log line format, where each log line includes severity, date/time, request_id and log message
  • Rescues untrapped errors and logs them along with a backtrace
  • Fixes the Etna::Controller#log function

@graft graft merged commit 47b6869 into master Dec 4, 2018
@graft
Copy link
Contributor Author

graft commented Dec 4, 2018

This is pretty basic and tests pass, merging.

@graft graft deleted the graft-add-error-logging branch April 19, 2020 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant