Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue38 expose client route path #40

Merged
merged 2 commits into from
May 14, 2020
Merged

Issue38 expose client route path #40

merged 2 commits into from
May 14, 2020

Conversation

coleshaw
Copy link
Collaborator

@coleshaw coleshaw commented May 13, 2020 •
edited
Loading

#38

Note that this change is on top of your graft-repair-hmac branch, so not on top of master.

Exposes the route_path method on Etna::Client as public, so it can be used by other applications to generate route paths.

@coleshaw coleshaw requested a review from graft May 13, 2020 19:36
@graft graft changed the base branch from graft-repair-hmac to master May 13, 2020 22:33
@graft
Copy link
Contributor

graft commented May 14, 2020

🚢

@coleshaw coleshaw merged commit 3633343 into master May 14, 2020
@coleshaw coleshaw deleted the issue38-expose-Client-route-path branch May 14, 2020 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graft graft Awaiting requested review from graft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coleshaw @graft