Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use uri.request_uri to get query params into HTTP connection #44

Merged
merged 2 commits into from
May 22, 2020

Conversation

coleshaw
Copy link
Collaborator

Close #43

If we want to convert everything to the standard library, then we can ignore this. Opening this because the Magma changes I'm making in mountetna/magma#139 depend on this behavior.

Copy link
Contributor

@graft graft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 should be safe since you're creating the first production use of Etna::Client.

@coleshaw coleshaw merged commit ce49a9f into master May 22, 2020
@coleshaw coleshaw deleted the issue43-pass-uri-query-params branch May 22, 2020 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in usage of persistent connections and query params
2 participants