with JS files from etna-js #57
Conversation
.github/workflows/tests.yml
Outdated
| run: | | ||
| npm run test | ||
| - name: Run test suite | ||
| if: ${{ steps.npm_test_run.outcome == 'success' }} |
There was a problem hiding this comment.
Does this need to be conditional? They could both run independently, in case JS tests are failing but we are working on ruby stuff...
There was a problem hiding this comment.
Hm....I would expect at least for master, that both JS and Ruby tests pass, so that any work on a feature branch should have the other tests passing. I would be worried about, if you don't make the last step conditional, that only the last system status code is flagged as the returned status of this step, so a failure in the second Ruby tests would get missed.
There was a problem hiding this comment.
We could also run a completely separate action for Ruby tests (as we are for Ruby gem pushes, and we might for npm pushes some day).
However, it seems like if any of the individual steps fail the whole action is marked as failing, and since you are running them as separate steps, the two steps could run independently, and only if both pass would the action be green?
There was a problem hiding this comment.
I like separate the separate action idea...
README.md
Outdated
| @@ -1,150 +1,8 @@ | |||
| # Mount Etna common library | |||
| These JavaScript components are shared across Mount Etna projects. You can install them via NPM into your project with: `npm install --save git+ssh://git@github.com:mountetna/etna-js.git` | |||
There was a problem hiding this comment.
This appears to be out of date here.
There was a problem hiding this comment.
Also it appears to be overwriting the existing README :) Most of the existing README should move to mountetna.github.io anyway though...
workers/README.md
Outdated
| @@ -0,0 +1,29 @@ | |||
| ## Upload Cycle Description. | |||
There was a problem hiding this comment.
This file should be deleted, it is very out of date.
|
The JS tests are very nicely written and cover a lot of important functionality, great work. Let's 🚢 so we can use this elsewhere and build further. |
Shall we consolidate the shared code here, including JavaScript? As suggested in mountetna/etna-js#3?
NOTE: the GH Action for this PR only runs the NPM tests. We should set it up so that it runs both Ruby and JS tests.