Add copy #59
Merged
Add copy #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@coleshaw should I close this? Is it superseded by your recent branches? |
|
This could be merged, but I wouldn’t just close it. My branches and PRs are based off of this branch, not master...
… On May 24, 2020, at 17:30, Saurabh Asthana ***@***.***> wrote:
@coleshaw should I close this? Is it superseded by your recent branches?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fills out #57, providing a basic copy facility to Metis. Following #53 copying files is easy and just produces a new database entry, no longer creating new bytes on disk. Consequently this PR is pretty simple, it just creates a new file entry.
The slight complication is checking bucket permissions for buckets not owned by Metis. This requires user-token authentication AND that the request be Hmac signed by the owning application (e.g. Magma). This was not possible before (notably the 'Authorization' field was shared by both means of authentication and thus produced a conflict); consequently this PR depends on upgrading the 'etna' gem to 0.1.9.