Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to answer forum for questions from mailing list. #78

Merged
merged 1 commit into from
Sep 28, 2016
Merged

Switch to answer forum for questions from mailing list. #78

merged 1 commit into from
Sep 28, 2016

Conversation

130s
Copy link
Contributor

@130s 130s commented Sep 27, 2016

No description provided.

@davetcoleman davetcoleman mentioned this pull request Sep 27, 2016
Closed
10 tasks
@130s
Copy link
Contributor Author

130s commented Sep 27, 2016

Please review @IanTheEngineer @davetcoleman

@v4hn
Copy link
Contributor

v4hn commented Sep 27, 2016

That was actually an idea I would have proposed today too. :)
The change looks good to me.

IanTheEngineer
IanTheEngineer approved these changes Sep 27, 2016
View reviewed changes
Copy link

@IanTheEngineer IanTheEngineer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for redacting my casual screencap :)

@130s
Copy link
Contributor Author

130s commented Sep 28, 2016

Thanks for the review.
Travis failed, maybe #77 needs merged first?

@v4hn
Copy link
Contributor

v4hn commented Sep 28, 2016

#77 has just been merged. please rebase.

@130s
Copy link
Contributor Author

130s commented Sep 28, 2016

Done and all-green.

@130s 130s merged commit 29b259e into moveit:gh-pages Sep 28, 2016
@130s 130s deleted the impr/answers.ros.org branch September 28, 2016 08:17
@130s
Copy link
Contributor Author

130s commented Sep 28, 2016

Reference; this change was supported from the community back in winter 2016.

Can @IanTheEngineer or anyone make an announcement to the mailinglist?

@v4hn
Copy link
Contributor

v4hn commented Sep 28, 2016

Hm, I just tried to follow your howto, but I keep getting a red box saying "must be unicode, not str" whenever I enter "moveit" (or anything else) into the input field for interesting tags.

Also, the "Support" page should probably mention answers.ros.org if we want to make users ask questions there.

Sorry for the late detailed feedback..

@130s 130s mentioned this pull request Sep 28, 2016
Closed
@davetcoleman
Copy link
Member

davetcoleman commented Sep 28, 2016 •
edited
Loading

The screenshot should be cropped and resized to fit within the website width:

screenshot from 2016-09-28 06-33-34

Thanks for updating the website @130s !

@v4hn
Copy link
Contributor

v4hn commented Sep 28, 2016

I filed #82 to shrink the image.

@130s 130s mentioned this pull request Sep 29, 2016
Closed
davetcoleman pushed a commit to davetcoleman/moveit.ros.org that referenced this pull request Aug 19, 2020
@130s
Merge pull request moveit#78 from 130s/impr/answers.ros.org
9566b0c 
Switch to answer forum for questions from mailing list.

Former-commit-id: 29b259e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v4hn v4hn v4hn approved these changes

@IanTheEngineer IanTheEngineer IanTheEngineer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@130s @v4hn @davetcoleman @IanTheEngineer