Update Ruby version for 22.04 #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhaschke
reviewed
May 31, 2023
Gemfile
Outdated
| gem 'rubyzip', '~> 2.3.0' | ||
| gem 'webrick', '~> 1.8', '>= 1.8.1' | ||
| gem "github-pages", group: :jekyll_plugins | ||
| gem 'html-proofer', '~> 3.4' |
There was a problem hiding this comment.
Why do you downgrade html-proofer to a really old version?
Gemfile
Outdated
| gem 'github-pages' | ||
| gem 'html-proofer', '~> 3.19.4' | ||
| gem 'rubyzip', '~> 2.3.0' | ||
| gem 'webrick', '~> 1.8', '>= 1.8.1' |
There was a problem hiding this comment.
Is it really necessary to enforce >= 1.8.1 as well? ~>1.8 means any version >= 1.8 but smaller 2.0. I guess the latest will be chosen anyway.
Gemfile
Outdated
| gem 'webrick', '~> 1.8', '>= 1.8.1' | ||
| gem "github-pages", group: :jekyll_plugins | ||
| gem 'html-proofer', '~> 3.4' | ||
| gem 'rubyzip', '~> 2.3', '>= 2.3.2' |
There was a problem hiding this comment.
See above.
Suggested change
| gem 'rubyzip', '~> 2.3', '>= 2.3.2' | |
| gem 'rubyzip', '~> 2.3' |
|
@rhaschke thank you for the review. I've fixed up this PR based on your feedback. The old version of htmlproofer was a mistake. |
|
I'll merge this. I tried looking into the html-proofer errors today and don't understand what is happening. I posted internally here about it, hoping someone who better understands this problem might help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #806