Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update collision-related comments #2382

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

Ghenohenomohe
Copy link
Contributor

Description

This PR fixes function comments that are described in opposite.
Correct description should be collisionCallback() checks collision and distanceCallback() checks distance.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@welcome
Copy link

welcome bot commented Oct 22, 2020

Thanks for helping in improving MoveIt and open source robotics!

@felixvd felixvd closed this Oct 23, 2020
@felixvd felixvd reopened this Oct 23, 2020
@codecov
Copy link

codecov bot commented Oct 23, 2020

Codecov Report

Merging #2382 into melodic-devel will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           melodic-devel    #2382      +/-   ##
=================================================
- Coverage          51.34%   51.29%   -0.04%     
=================================================
  Files                322      322              
  Lines              23142    23142              
=================================================
- Hits               11880    11869      -11     
- Misses             11262    11273      +11     
Impacted Files Coverage Δ
.../moveit/collision_detection_fcl/collision_common.h 98.28% <ø> (ø)
.../ompl_interface/src/detail/constrained_sampler.cpp 42.86% <0.00%> (-17.14%) ⬇️
...nning_scene_monitor/src/planning_scene_monitor.cpp 66.94% <0.00%> (-0.47%) ⬇️
moveit_core/planning_scene/src/planning_scene.cpp 54.51% <0.00%> (-0.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3da197e...722e3cf. Read the comment docs.

@felixvd
Copy link
Contributor

felixvd commented Oct 23, 2020

Travis said "Expected — Waiting for status to be reported" but a younger build had passed, so I restarted the build.

@AndyZe AndyZe merged commit ff552bf into moveit:melodic-devel Oct 23, 2020
@welcome
Copy link

welcome bot commented Oct 23, 2020

Congrats on getting your first MoveIt pull request merged and improving open source robotics!

@AndyZe AndyZe changed the title Fix comments Update collision-related comments Oct 23, 2020
@felixvd
Copy link
Contributor

felixvd commented Oct 23, 2020

Thanks for the PR! @Ghenohenomohe

tylerjw pushed a commit that referenced this pull request Nov 6, 2020
Co-authored-by: Ghenohenomohe <71963599+Ghenohenomohe@users.noreply.github.com>
@tylerjw tylerjw mentioned this pull request Apr 9, 2021
@tylerjw tylerjw mentioned this pull request Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants