Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stomp Smoothing Planning Request Adapter #1081

Conversation

raghavendersahdev
Copy link
Contributor

Addition of STOMP Smoothing Adapter in MoveIt

This PR is work done by Raghavender as a part of 2018 Google summer of code. As a part of this PR, a STOMP Smoothing adapter has been implemented. This enables the user to use STOMP as an additional post processing motion planning algorithm in a pipeline with another motion planner like CHOMP, OMPL, etc. This then produces smooth motion plans.

For tutorials on how to use this motion planning request adapter, refer to PR for a tutorial on Planning Request Adapters PR#220 . This PR also needs this PR in industrial_moveit package to be merged PR#78 in order for the STOMP smoothing adapter to function properly.
It should be noted this PR overrides an older PR #965 , after this PR gets merged PR #965 can be closed and ignored.
@davetcoleman @mamoll

Checklist

  • addition of STOMP smoothing adapter into existing MoveIt Planning Request Adapters
  • merging of the STOMP moveit package from industrial moveit into moveit, this PR overrides this PR added STOMP planner in moveit_planners #965

@@ -24,3 +24,7 @@
local-name: srdfdom
uri: https://github.com/ros-planning/srdfdom.git
version: kinetic-devel
- git:
local-name: industrial_moveit
uri: https://github.com/raghavendersahdev/industrial_moveit.git
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be switched to the new stomp repo that is suppose to be created. fyi @gavanderhoorn

@rhaschke
Copy link
Contributor

Please revert the last merge-commit and rebase your branch onto the kinetic-devel to resolve conflicts.
Having merge-commits within a PR-branch like this, makes it impossible to squash, or cherry-pick it to another branch later on.

@v4hn v4hn added the more work needed Everyone is invited to contribute label Dec 18, 2018
@henningkayser
Copy link
Member

@raghavendersahdev what's the current state of this PR? It would be great to get this feature merged. I just think since we have the separate STOMP repo now the smoothing adapter should be added to https://github.com/ros-industrial/stomp_ros instead of here. @gavanderhoorn what do you think?

@v4hn
Copy link
Contributor

v4hn commented May 11, 2020

Obsolete. The plugin is available in ros-industrial/stomp_ros#20

@v4hn v4hn closed this May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
more work needed Everyone is invited to contribute
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants