Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating an experimental moveit docker image - warehouse / mongo #146

Merged
merged 5 commits into from
Aug 26, 2016

Conversation

ugocupcic
Copy link
Contributor

@davetcoleman
Copy link
Member

Can you add to this PR an explanation of this experimental docker in .docker/README.md?

# moveit/moveit:kinetic-experimental
# Based on a moveit source install, adds the mongo driver and the warehouse packages

FROM moveit/moveit:kinetic-source
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you build on top of kinetic-source you should use CATKIN_WS = /root/ws_moveit like the underlying container did

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it'd be cleaner to have an overlay? Happy to moveit to the same workspace

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah i see, ok

@davetcoleman
Copy link
Member

We don't have an easy way to test this in the cloud, but I'm testing the container build locally using:

docker build -t moveit/moveit:kinetic-experimental .

@ugocupcic
Copy link
Contributor Author

Nod, If you want the prebuilt one I've pushed it to shadowrobot/moveit:kinetic-experimental. I'm rebuilding to test with one workspace only. Will push as soon as it finishes buiding.

@davetcoleman
Copy link
Member

The image built fine locally!

Should this be cherry-picked to I/J? Seems like indigo had no issue with mongo so it wouldn't be needed there

@ugocupcic
Copy link
Contributor Author

probably jade at least right? For indigo I was under the impression that you don't need all the work to get it working - apt-get install ros...warehouse is enough no?

@ugocupcic
Copy link
Contributor Author

@davetcoleman I think it's ready now? it's building happily with one workspace

@ugocupcic
Copy link
Contributor Author

By the way, you might want to send an email around since the existing moveit configuration would need to be edited to work with the warehouse? Not sure how best to share that info.

@davetcoleman davetcoleman merged commit 41766c3 into moveit:kinetic-devel Aug 26, 2016
davetcoleman pushed a commit that referenced this pull request Aug 26, 2016
* Building warehouse with all its needed deps

* fixing git urls and versions

* missing mongodbgit df

* updated README

* keeping everything in the moveit ws
@davetcoleman
Copy link
Member

Thanks @ugocupcic, I've cherry-picked to Jade and turned on the build on dockerhub

By the way, you might want to send an email around since the existing moveit configuration would need to be edited to work with the warehouse?

Did the other PR concerning this already get merged in? If so, I think you should make the announcement yourself

sjahr pushed a commit to sjahr/moveit that referenced this pull request Jun 21, 2024
* Add new error types (moveit_msgs moveit#146)

* Add default case

* Small change to the default case

Co-authored-by: Tyler Weaver <maybe@tylerjw.dev>

Co-authored-by: Tyler Weaver <maybe@tylerjw.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants