-
Notifications
You must be signed in to change notification settings - Fork 947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating an experimental moveit docker image - warehouse / mongo #146
Creating an experimental moveit docker image - warehouse / mongo #146
Conversation
Can you add to this PR an explanation of this experimental docker in |
# moveit/moveit:kinetic-experimental | ||
# Based on a moveit source install, adds the mongo driver and the warehouse packages | ||
|
||
FROM moveit/moveit:kinetic-source |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you build on top of kinetic-source you should use CATKIN_WS = /root/ws_moveit like the underlying container did
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it'd be cleaner to have an overlay? Happy to moveit to the same workspace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah i see, ok
We don't have an easy way to test this in the cloud, but I'm testing the container build locally using:
|
Nod, If you want the prebuilt one I've pushed it to shadowrobot/moveit:kinetic-experimental. I'm rebuilding to test with one workspace only. Will push as soon as it finishes buiding. |
The image built fine locally! Should this be cherry-picked to I/J? Seems like indigo had no issue with mongo so it wouldn't be needed there |
probably jade at least right? For indigo I was under the impression that you don't need all the work to get it working - apt-get install ros...warehouse is enough no? |
@davetcoleman I think it's ready now? it's building happily with one workspace |
By the way, you might want to send an email around since the existing moveit configuration would need to be edited to work with the warehouse? Not sure how best to share that info. |
* Building warehouse with all its needed deps * fixing git urls and versions * missing mongodbgit df * updated README * keeping everything in the moveit ws
Thanks @ugocupcic, I've cherry-picked to Jade and turned on the build on dockerhub
Did the other PR concerning this already get merged in? If so, I think you should make the announcement yourself |
* Add new error types (moveit_msgs moveit#146) * Add default case * Small change to the default case Co-authored-by: Tyler Weaver <maybe@tylerjw.dev> Co-authored-by: Tyler Weaver <maybe@tylerjw.dev>
As discussed in https://github.com/ros-planning/moveit_docker/pull/3