Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python wrapper] add acceleration_scaling_factor to retime_trajectory #1506

Closed
wants to merge 1 commit into from

Conversation

mmurooka
Copy link
Contributor

Description

Example code:

plan_retimed = self.move_group.retime_trajectory(
    reference_state, plan,
    # velocity_scaling_factor=1.0, # can be omitted if 1.0
    acceleration_scaling_factor=0.1) # this argument becomes supported by this PR.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extended the tutorials / documentation, if necessary reference
  • Include a screenshot if changing a GUI
  • Document API changes relevant to the user in the moveit/MIGRATION.md notes
  • Created tests, which fail without this PR reference
  • Decide if this should be cherry-picked to other current ROS branches
  • While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers

@welcome
Copy link

welcome bot commented Jun 18, 2019

Thanks for helping in improving MoveIt!

Copy link
Contributor

@felixvd felixvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested it myself, but I see nothing wrong with this. I'm all for exposing more variables in Python.

@v4hn
Copy link
Contributor

v4hn commented Jul 4, 2019

This was already merged as part of #1508

@v4hn v4hn closed this Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants