Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo "trajactory" in moveit_py #2947

Closed
christian-rauch opened this issue Aug 5, 2024 · 3 comments · Fixed by #2951
Closed

typo "trajactory" in moveit_py #2947

christian-rauch opened this issue Aug 5, 2024 · 3 comments · Fixed by #2951
Labels
bug Something isn't working

Comments

@christian-rauch
Copy link
Member

Description

There is a typo "trajactory" -> "trajectory" in moveit_py:

.def("get_trajactory_execution_manager", &moveit_cpp::MoveItCpp::getTrajectoryExecutionManagerNonConst,
py::return_value_policy::reference,
R"(
Returns the trajectory execution manager.
)")

Unfortunately, fixing this typo will break API.

Expected behaviour

The method should be named get_trajectory_execution_manager.

Actual behaviour

The method is incorrectly named get_trajactory_execution_manager.

@christian-rauch christian-rauch added the bug Something isn't working label Aug 5, 2024
@sjahr
Copy link
Contributor

sjahr commented Aug 5, 2024

@christian-rauch Thanks for reporting this. Would you mind opening a PR to fix it?

@akky20
Copy link
Contributor

akky20 commented Aug 6, 2024

@sjahr I have raised a PR for this, can you please have a look into it

@github-project-automation github-project-automation bot moved this to ✅ Done in MoveIt Aug 6, 2024
@JensVanhooydonck
Copy link
Contributor

I guess there is still a typo in the pyi file:

def get_trajactory_execution_manager(self, *args, **kwargs) -> Any: ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants