Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove bind #1204

Merged
merged 8 commits into from
May 10, 2022
Merged

Remove bind #1204

merged 8 commits into from
May 10, 2022

Commits on May 5, 2022

  1. simplify distance field method binding 

    source: moveit/moveit@0322d63
    @v4hn @peterdavidfagan
    v4hn authored and peterdavidfagan committed May 5, 2022
    Configuration menu
    Copy the full SHA
    ddc931e View commit details
    Browse the repository at this point in the history

  2. drop unused arguments not needed for lambda binding 

    source: moveit/moveit@6805b7e ; I have also had to update how moveit_msgs is referenced (movit_msgs:: -> moveit_msgs::msg:: ) and I  added the changes to this commit that correspond to tests for the constraint samplers package.
    @v4hn @peterdavidfagan
    v4hn authored and peterdavidfagan committed May 5, 2022
    Configuration menu
    Copy the full SHA
    fd21421 View commit details
    Browse the repository at this point in the history

  3. migrate PRA internals to lambdas 

    source: moveit/moveit@6436597; in addition to the original commit I updated logging to support ros2 logging standards.
    @v4hn @peterdavidfagan
    v4hn authored and peterdavidfagan committed May 5, 2022
    Configuration menu
    Copy the full SHA
    76a52c1 View commit details
    Browse the repository at this point in the history

  4. remove unused arguments from kinematics test 

    source moveit/moveit@ddb68b6; I also had to amend moveit_msgs to moveit_msgs::msg in this commit, otherwise everything remains the same as source commit. When I ran the kinematics plugin test locally it threw an error both before and after this change. Hopefully we can revisit this point as part of the code review, the error related to the robot description.
    @v4hn @peterdavidfagan
    v4hn authored and peterdavidfagan committed May 5, 2022
    Configuration menu
    Copy the full SHA
    8262fcc View commit details
    Browse the repository at this point in the history

  5. planning_context_manager: rename protected methods 

    sources: moveit/moveit@a183bc1, moveit/moveit@c07be63;
    @rhaschke @peterdavidfagan
    rhaschke authored and peterdavidfagan committed May 5, 2022
    Configuration menu
    Copy the full SHA
    9c832b3 View commit details
    Browse the repository at this point in the history

  6. various: prefer object and references over pointers 

    source: moveit/moveit@1a8e571; this commit contains minor changes when compared to the source commit which it is based on, these changes are limited to ensuring compatibility with ROS2.
    @v4hn @peterdavidfagan
    v4hn authored and peterdavidfagan committed May 5, 2022
    Configuration menu
    Copy the full SHA
    e488102 View commit details
    Browse the repository at this point in the history

  7. banish bind() 

    source:moveit/moveit@a2911c8; required minor updates compared to original source commit in order to ensure compatibility with ROS2
    @v4hn @peterdavidfagan
    v4hn authored and peterdavidfagan committed May 5, 2022
    Configuration menu
    Copy the full SHA
    7793df0 View commit details
    Browse the repository at this point in the history

  8. add check for bind() to clang-tidy

    @v4hn @peterdavidfagan
    v4hn authored and peterdavidfagan committed May 5, 2022
    Configuration menu
    Copy the full SHA
    59a1307 View commit details
    Browse the repository at this point in the history