Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr hybrid planning review #351

Conversation

henningkayser
Copy link
Member

@henningkayser henningkayser commented Jan 29, 2021

Fixes addressing mostly MoveIt best practices. @sjahr

@codecov
Copy link

codecov bot commented Jan 29, 2021

Codecov Report

Merging #351 (90b259c) into feature/hybrid_planning (41afba5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                   Coverage Diff                    @@
##           feature/hybrid_planning     #351   +/-   ##
========================================================
  Coverage                    48.00%   48.00%           
========================================================
  Files                          157      157           
  Lines                        14843    14843           
========================================================
  Hits                          7124     7124           
  Misses                        7719     7719           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41afba5...90b259c. Read the comment docs.

Copy link
Contributor

@sjahr sjahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@henningkayser henningkayser merged commit f33df4b into moveit:feature/hybrid_planning Feb 1, 2021
sjahr pushed a commit to sjahr/moveit2 that referenced this pull request Apr 16, 2021
* Export missing plugins
* Use std::chrono_literals
* Construct smart pointers with std::make_* instead of 'new'
* Fixup const-ref in function signatures, reduce copies
* Improve planning scene locking, robot state processing, controller logic
sjahr pushed a commit to sjahr/moveit2 that referenced this pull request May 4, 2021
* Export missing plugins
* Use std::chrono_literals
* Construct smart pointers with std::make_* instead of 'new'
* Fixup const-ref in function signatures, reduce copies
* Improve planning scene locking, robot state processing, controller logic
sjahr pushed a commit to sjahr/moveit2 that referenced this pull request May 4, 2021
* Export missing plugins
* Use std::chrono_literals
* Construct smart pointers with std::make_* instead of 'new'
* Fixup const-ref in function signatures, reduce copies
* Improve planning scene locking, robot state processing, controller logic
sjahr pushed a commit to sjahr/moveit2 that referenced this pull request May 9, 2021
* Export missing plugins
* Use std::chrono_literals
* Construct smart pointers with std::make_* instead of 'new'
* Fixup const-ref in function signatures, reduce copies
* Improve planning scene locking, robot state processing, controller logic
henningkayser added a commit that referenced this pull request May 18, 2021
* Export missing plugins
* Use std::chrono_literals
* Construct smart pointers with std::make_* instead of 'new'
* Fixup const-ref in function signatures, reduce copies
* Improve planning scene locking, robot state processing, controller logic
henningkayser added a commit that referenced this pull request May 18, 2021
* Export missing plugins
* Use std::chrono_literals
* Construct smart pointers with std::make_* instead of 'new'
* Fixup const-ref in function signatures, reduce copies
* Improve planning scene locking, robot state processing, controller logic
sjahr pushed a commit to sjahr/moveit2 that referenced this pull request Jun 4, 2021
* Export missing plugins
* Use std::chrono_literals
* Construct smart pointers with std::make_* instead of 'new'
* Fixup const-ref in function signatures, reduce copies
* Improve planning scene locking, robot state processing, controller logic
sjahr pushed a commit to sjahr/moveit2 that referenced this pull request Jun 4, 2021
* Export missing plugins
* Use std::chrono_literals
* Construct smart pointers with std::make_* instead of 'new'
* Fixup const-ref in function signatures, reduce copies
* Improve planning scene locking, robot state processing, controller logic
sjahr pushed a commit to sjahr/moveit2 that referenced this pull request Jun 7, 2021
* Export missing plugins
* Use std::chrono_literals
* Construct smart pointers with std::make_* instead of 'new'
* Fixup const-ref in function signatures, reduce copies
* Improve planning scene locking, robot state processing, controller logic
sjahr pushed a commit to sjahr/moveit2 that referenced this pull request Jun 7, 2021
* Export missing plugins
* Use std::chrono_literals
* Construct smart pointers with std::make_* instead of 'new'
* Fixup const-ref in function signatures, reduce copies
* Improve planning scene locking, robot state processing, controller logic
henningkayser added a commit to henningkayser/moveit2 that referenced this pull request Jul 6, 2021
* Export missing plugins
* Use std::chrono_literals
* Construct smart pointers with std::make_* instead of 'new'
* Fixup const-ref in function signatures, reduce copies
* Improve planning scene locking, robot state processing, controller logic
sjahr pushed a commit to sjahr/moveit2 that referenced this pull request Aug 21, 2021
* Export missing plugins
* Use std::chrono_literals
* Construct smart pointers with std::make_* instead of 'new'
* Fixup const-ref in function signatures, reduce copies
* Improve planning scene locking, robot state processing, controller logic
sjahr pushed a commit to sjahr/moveit2 that referenced this pull request Sep 28, 2021
* Export missing plugins
* Use std::chrono_literals
* Construct smart pointers with std::make_* instead of 'new'
* Fixup const-ref in function signatures, reduce copies
* Improve planning scene locking, robot state processing, controller logic
sjahr pushed a commit to sjahr/moveit2 that referenced this pull request Oct 19, 2021
* Export missing plugins
* Use std::chrono_literals
* Construct smart pointers with std::make_* instead of 'new'
* Fixup const-ref in function signatures, reduce copies
* Improve planning scene locking, robot state processing, controller logic
sjahr pushed a commit to sjahr/moveit2 that referenced this pull request Oct 28, 2021
* Export missing plugins
* Use std::chrono_literals
* Construct smart pointers with std::make_* instead of 'new'
* Fixup const-ref in function signatures, reduce copies
* Improve planning scene locking, robot state processing, controller logic
sjahr pushed a commit to sjahr/moveit2 that referenced this pull request Nov 18, 2021
* Export missing plugins
* Use std::chrono_literals
* Construct smart pointers with std::make_* instead of 'new'
* Fixup const-ref in function signatures, reduce copies
* Improve planning scene locking, robot state processing, controller logic
AndyZe pushed a commit to AndyZe/moveit2 that referenced this pull request Nov 24, 2021
* Export missing plugins
* Use std::chrono_literals
* Construct smart pointers with std::make_* instead of 'new'
* Fixup const-ref in function signatures, reduce copies
* Improve planning scene locking, robot state processing, controller logic
AndyZe pushed a commit to AndyZe/moveit2 that referenced this pull request Nov 29, 2021
* Export missing plugins
* Use std::chrono_literals
* Construct smart pointers with std::make_* instead of 'new'
* Fixup const-ref in function signatures, reduce copies
* Improve planning scene locking, robot state processing, controller logic
AndyZe pushed a commit to AndyZe/moveit2 that referenced this pull request Nov 30, 2021
* Export missing plugins
* Use std::chrono_literals
* Construct smart pointers with std::make_* instead of 'new'
* Fixup const-ref in function signatures, reduce copies
* Improve planning scene locking, robot state processing, controller logic
AndyZe pushed a commit to AndyZe/moveit2 that referenced this pull request Dec 3, 2021
* Export missing plugins
* Use std::chrono_literals
* Construct smart pointers with std::make_* instead of 'new'
* Fixup const-ref in function signatures, reduce copies
* Improve planning scene locking, robot state processing, controller logic
AndyZe pushed a commit to AndyZe/moveit2 that referenced this pull request Dec 7, 2021
* Export missing plugins
* Use std::chrono_literals
* Construct smart pointers with std::make_* instead of 'new'
* Fixup const-ref in function signatures, reduce copies
* Improve planning scene locking, robot state processing, controller logic
AndyZe pushed a commit to AndyZe/moveit2 that referenced this pull request Dec 7, 2021
* Export missing plugins
* Use std::chrono_literals
* Construct smart pointers with std::make_* instead of 'new'
* Fixup const-ref in function signatures, reduce copies
* Improve planning scene locking, robot state processing, controller logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants