Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Visualizing in RViz Tutorial #365

Merged
merged 4 commits into from
May 20, 2022
Merged

Conversation

tylerjw
Copy link
Member

@tylerjw tylerjw commented May 17, 2022

This PR is based on:

Description

This new tutorial should introduce new users to MoveItVisualTools very quickly and provide some links for how they can learn more about its features and use cases.

Copy link
Contributor

@stephanie-eng stephanie-eng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still need to follow along with the steps and try this, but for now I've left some comments on spelling/grammar

doc/tutorials/visualizing_in_rviz/visualizing_in_rviz.rst Outdated Show resolved Hide resolved
doc/tutorials/visualizing_in_rviz/visualizing_in_rviz.rst Outdated Show resolved Hide resolved
doc/tutorials/visualizing_in_rviz/visualizing_in_rviz.rst Outdated Show resolved Hide resolved
doc/tutorials/visualizing_in_rviz/visualizing_in_rviz.rst Outdated Show resolved Hide resolved
doc/tutorials/visualizing_in_rviz/visualizing_in_rviz.rst Outdated Show resolved Hide resolved
doc/tutorials/visualizing_in_rviz/visualizing_in_rviz.rst Outdated Show resolved Hide resolved
doc/tutorials/visualizing_in_rviz/visualizing_in_rviz.rst Outdated Show resolved Hide resolved
doc/tutorials/visualizing_in_rviz/visualizing_in_rviz.rst Outdated Show resolved Hide resolved
doc/tutorials/visualizing_in_rviz/visualizing_in_rviz.rst Outdated Show resolved Hide resolved
doc/tutorials/visualizing_in_rviz/visualizing_in_rviz.rst Outdated Show resolved Hide resolved
@mergify
Copy link

mergify bot commented May 19, 2022

This pull request is in conflict. Could you fix it @tylerjw?

@tylerjw tylerjw force-pushed the visualizing_in_rviz branch 2 times, most recently from aada95e to a634b46 Compare May 20, 2022 01:44
Copy link
Contributor

@abake48 abake48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working on running through the tutorial right now but I have a few nitpicky grammatical suggestions from my read through.

doc/tutorials/visualizing_in_rviz/visualizing_in_rviz.rst Outdated Show resolved Hide resolved
doc/tutorials/visualizing_in_rviz/visualizing_in_rviz.rst Outdated Show resolved Hide resolved
doc/tutorials/visualizing_in_rviz/visualizing_in_rviz.rst Outdated Show resolved Hide resolved
doc/tutorials/visualizing_in_rviz/visualizing_in_rviz.rst Outdated Show resolved Hide resolved
doc/tutorials/visualizing_in_rviz/visualizing_in_rviz.rst Outdated Show resolved Hide resolved
doc/tutorials/visualizing_in_rviz/visualizing_in_rviz.rst Outdated Show resolved Hide resolved
@mergify
Copy link

mergify bot commented May 20, 2022

This pull request is in conflict. Could you fix it @tylerjw?

tylerjw and others added 2 commits May 20, 2022 10:48
Signed-off-by: Tyler Weaver <tyler@picknik.ai>
Co-authored-by: Stephanie Eng <stephanie-eng@users.noreply.github.com>
Co-authored-by: Anthony Baker <abake48@users.noreply.github.com>
@tylerjw
Copy link
Member Author

tylerjw commented May 20, 2022

Working on running through the tutorial right now but I have a few nitpicky grammatical suggestions from my read through.

I've accepted your changes, would you mind re-reviewing this?

Copy link
Contributor

@abake48 abake48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple more changes and I'll feel comfortable approving this PR

doc/tutorials/visualizing_in_rviz/visualizing_in_rviz.rst Outdated Show resolved Hide resolved
doc/tutorials/visualizing_in_rviz/visualizing_in_rviz.rst Outdated Show resolved Hide resolved
Co-authored-by: Anthony Baker <abake48@users.noreply.github.com>
Copy link
Contributor

@abake48 abake48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tylerjw tylerjw merged commit 641c0b8 into moveit:main May 20, 2022
@tylerjw tylerjw deleted the visualizing_in_rviz branch May 20, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants