Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to hide visualized robot states #55

Merged
merged 9 commits into from
Aug 14, 2019
Merged

Ability to hide visualized robot states #55

Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
806bbc4
Ability to hide visualized robot states
davetcoleman Aug 7, 2019
039f7d6
Update msg/DisplayRobotState.msg
davetcoleman Aug 13, 2019
0a560ca
Update msg/DisplayRobotState.msg
davetcoleman Aug 13, 2019
ac1b372
Update DisplayRobotState.msg
davetcoleman Aug 13, 2019
aae565f
Update DisplayRobotState.msg
davetcoleman Aug 14, 2019
be5cb8e
fixup
rhaschke Aug 14, 2019
c5c2c80
alternative wording
v4hn Aug 14, 2019
27a576a
yet another wording
rhaschke Aug 14, 2019
3671994
reword once more
v4hn Aug 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions msg/DisplayRobotState.msg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,7 @@ RobotState state

# Optionally, various links can be highlighted
ObjectColor[] highlight_links

# Optionally, do not display this state in visualizations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like the wording "this state" here, as - if hide is true - there is no need to provide a RobotState at all.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also optional is kind of misleading here. An array can be empty (and thus optional), but a simple scalar variable cannot be optional. However, the default value of zero (false) is very useful here 😉

# and hide previously sent states
bool hide_display
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I changed back to hide intentionally (but I should have commented).
This variable never stands on its own, but it's always used with a prefix like display_robot_state.hide. In this context, I think the short name is sufficient.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense and I agree.