Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator-sdk update from v0.17.1 to v0.18.0 #56

Merged
merged 3 commits into from
Feb 26, 2022

Conversation

hitman99
Copy link
Member

@hitman99 hitman99 commented Oct 8, 2020

Needs e2e testing as it might break things

@reddec
Copy link
Contributor

reddec commented Dec 17, 2021

Hi! @hitman99 any updates on this? Seems like it should solve problem with CRD

@hitman99
Copy link
Member Author

I have some time allocated next week to work on this project and will do a new release of the operator with these changes.

@reddec
Copy link
Contributor

reddec commented Dec 17, 2021

Thanks!

@hitman99 hitman99 requested a review from arnarg December 22, 2021 12:33
@hitman99
Copy link
Member Author

Hey @arnarg, does this look ok? There's a lot of changes, but all were done by operator-sdk upgrade docs. The major difference is apiextensions.k8s.io/v1beta1 upgrade to apiextensions.k8s.io/v1. Starting from kubernetes v1.22 the v1beta1 is deprecated and no longer served. I've tested the v1 CRDs and it works well.

Copy link

@arnarg arnarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@endersonmaia
Copy link
Contributor

this PR should close #73

@tuler
Copy link

tuler commented Feb 25, 2022

Any expectation of merging this?
Thanks

@hitman99 hitman99 merged commit 8dc33d0 into master Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants