Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typescript definitions #28

Closed
wants to merge 1 commit into from
Closed

Conversation

jsamr
Copy link

@jsamr jsamr commented Jan 23, 2019

Add index.d.ts :-)

@codecov
Copy link

codecov bot commented Jan 23, 2019

Codecov Report

Merging #28 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #28   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          28     28           
  Branches       11     11           
=====================================
  Hits           28     28

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2c65f1...db71195. Read the comment docs.

@satazor
Copy link
Contributor

satazor commented Jan 23, 2019

Thanks for the effort in doing the PR but I will have to close it. While it does add the benefit of having typings for typescript users consuming this module, it will add a maintenance burden, specially since this module is not written in typescript.

Again, I’m sorry and hope you understand.

@satazor satazor closed this Jan 23, 2019
@jsamr
Copy link
Author

jsamr commented Jan 23, 2019

@satazor ; well, I understand the maintenance burden you are consciously avoiding. However your API surface is very thin, and you could ping me on releases to get the job done.

Either that or I'll publish the definitions to definitely typed.

@satazor
Copy link
Contributor

satazor commented Jan 23, 2019

Exactly, it’s to avoid the maintenance burden. I know it’s thin but today is typescript, tomorrow is flow, and in the future is something else.

I would publish the definitions to definitively typed. 🙏

@jsamr
Copy link
Author

jsamr commented Oct 17, 2019

@satazor DefinitelyTyped/DefinitelyTyped#39197
Should land soon.

@jsamr
Copy link
Author

jsamr commented Oct 17, 2019

@satazor Please mention me on any API changes and I'll offer a PR in DT.

@jsamr
Copy link
Author

jsamr commented Oct 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants