Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you were using this template to create a component that was using react hooks, you might have faced this error:
You can read more about "Invalid Hook Calls" but long story short: we were having duplicated
React
module.Why?
This is a common problem while using
npm-link
. The bundler was detecting twoReacts
: one in our demo folder and the other one in our component folder.Related issues:
Solution
To solve this problem 2 possibilities were considered:
react
andreact-dom
modules and remove them as dependencies from the demo's package.json file.npm-link
on our component to use the demo's react module.This PR implements the solution 1. as it seems to be the best one. Solution 2. would require developers to run
npm i
insidedemo/
before creating thenpm-link
. If we had chosen solution 2., the process could be either documented or semi-automated withnpm scripts
but it would be error-prone and we would be adding scripts to our final package (which IMO is not cool).With the current solution, the work process is the same as it was before. It doesn't add any extra step or extra effort.