Skip to content
This repository has been archived by the owner on Nov 3, 2021. It is now read-only.

Add the entry point script for install all system packages #43

Merged
merged 1 commit into from
Jan 14, 2016

Conversation

askeing
Copy link
Contributor

@askeing askeing commented Jan 13, 2016

No description provided.

@askeing
Copy link
Contributor Author

askeing commented Jan 13, 2016

ref: #35

@@ -0,0 +1,11 @@
#!/bin/bash

MOZITP="/home/vagrant/MozITP"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a global config.sh or something that contains this kind of global env variable. And in every script we can source config.sh to get them.

You can see MOZITP appears in scripts/install/system/provision.sh again, and I believe we can use it in many other scripts as well. The config.sh can contain things like default system path, default node/npm version, etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree

@askeing
Copy link
Contributor Author

askeing commented Jan 13, 2016

@shinglyu add config.sh seems like have some path issue, we should just merge this PR for entry point case, and then creat a new issue for config case.

@askeing
Copy link
Contributor Author

askeing commented Jan 14, 2016

@shinglyu r?

shinglyu added a commit that referenced this pull request Jan 14, 2016
Add the entry point script for install all system packages
@shinglyu shinglyu merged commit 39bdda9 into mozilla-b2g:master Jan 14, 2016
@askeing askeing deleted the split_system_install_script branch January 14, 2016 05:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants