Skip to content

Commit 072abd2

Browse files
committed
Bug 1969980 - [part 16] Remove wallpaper updated snackbar r=android-reviewers,mavduevskiy
Differential Revision: https://phabricator.services.mozilla.com/D262465
1 parent 5f7eead commit 072abd2

File tree

2 files changed

+2
-18
lines changed

2 files changed

+2
-18
lines changed

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/wallpaper/WallpaperSettingsFragment.kt

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -14,15 +14,13 @@ import androidx.compose.ui.platform.ViewCompositionStrategy
1414
import androidx.coordinatorlayout.widget.CoordinatorLayout
1515
import androidx.fragment.app.Fragment
1616
import androidx.lifecycle.lifecycleScope
17-
import androidx.navigation.fragment.findNavController
1817
import kotlinx.coroutines.launch
1918
import mozilla.components.lib.state.ext.observeAsComposableState
2019
import mozilla.telemetry.glean.private.NoExtras
2120
import org.mozilla.fenix.BrowserDirection
2221
import org.mozilla.fenix.GleanMetrics.Wallpapers
2322
import org.mozilla.fenix.HomeActivity
2423
import org.mozilla.fenix.R
25-
import org.mozilla.fenix.browser.browsingmode.BrowsingMode
2624
import org.mozilla.fenix.compose.core.Action
2725
import org.mozilla.fenix.compose.snackbar.Snackbar
2826
import org.mozilla.fenix.compose.snackbar.SnackbarState
@@ -107,20 +105,6 @@ class WallpaperSettingsFragment : Fragment() {
107105
) {
108106
when (result) {
109107
Wallpaper.ImageFileState.Downloaded -> {
110-
Snackbar.make(
111-
snackBarParentView = view,
112-
snackbarState = SnackbarState(
113-
message = getString(R.string.wallpaper_updated_snackbar_message),
114-
action = Action(
115-
label = getString(R.string.wallpaper_updated_snackbar_action),
116-
onClick = {
117-
(activity as HomeActivity).browsingModeManager.mode = BrowsingMode.Normal
118-
findNavController().navigate(R.id.homeFragment)
119-
},
120-
),
121-
),
122-
).show()
123-
124108
Wallpapers.wallpaperSelected.record(
125109
Wallpapers.WallpaperSelectedExtra(
126110
name = wallpaper.name,

mobile/android/fenix/app/src/main/res/values/strings.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -821,9 +821,9 @@
821821
<!-- Content description for various wallpapers. %1$s is the name of the wallpaper. -->
822822
<string name="wallpapers_item_name_content_description">Wallpaper Item: %1$s</string>
823823
<!-- Snackbar message for when wallpaper is selected -->
824-
<string name="wallpaper_updated_snackbar_message">Wallpaper updated!</string>
824+
<string name="wallpaper_updated_snackbar_message" tools:ignore="UnusedResources" moz:removedIn="144">Wallpaper updated!</string>
825825
<!-- Snackbar label for action to view selected wallpaper -->
826-
<string name="wallpaper_updated_snackbar_action">View</string>
826+
<string name="wallpaper_updated_snackbar_action" tools:ignore="UnusedResources" moz:removedIn="144">View</string>
827827
<!-- Snackbar message for when wallpaper couldn't be downloaded -->
828828
<string name="wallpaper_download_error_snackbar_message">Couldn’t download wallpaper</string>
829829
<!-- Snackbar label for action to retry downloading the wallpaper -->

0 commit comments

Comments
 (0)