Bug 1943057 - Remove pref extensions.webextensions.userScripts.enabled r=extension-reviewers,robwu

Differential Revision: https://phabricator.services.mozilla.com/D258823

Author: mr-cheffy

modules/libpref/init/all.js

@@ -3137,7 +3137,6 @@ pref("extensions.originControls.grantByDefault", true);
 pref("extensions.webextensions.protocol.remote", true);
 
 // Enable userScripts API by default.
-pref("extensions.webextensions.userScripts.enabled", true);
 pref("extensions.userScripts.mv3.enabled", true);
 
 // Whether or not the installed extensions should be migrated to the storage.local IndexedDB backend.

toolkit/components/extensions/child/ext-userScripts-content.js

@@ -6,22 +6,10 @@
 
 "use strict";
 
-var USERSCRIPT_PREFNAME = "extensions.webextensions.userScripts.enabled";
-var USERSCRIPT_DISABLED_ERRORMSG = `userScripts APIs are currently experimental and must be enabled with the ${USERSCRIPT_PREFNAME} preference.`;
-
 ChromeUtils.defineESModuleGetters(this, {
   Schemas: "resource://gre/modules/Schemas.sys.mjs",
 });
 
-XPCOMUtils.defineLazyPreferenceGetter(
-  this,
-  "userScriptsEnabled",
-  USERSCRIPT_PREFNAME,
-  false
-);
-
-var { ExtensionError } = ExtensionUtils;
-
 const TYPEOF_PRIMITIVES = ["bigint", "boolean", "number", "string", "symbol"];
 
 /**
@@ -371,10 +359,6 @@ this.userScriptsContent = class extends ExtensionAPI {
           context,
           name: "userScripts.onBeforeScript",
           register: fire => {
-            if (!userScriptsEnabled) {
-              throw new ExtensionError(USERSCRIPT_DISABLED_ERRORMSG);
-            }
-
             let handler = (event, metadata, scriptSandbox) => {
               const us = new UserScript({
                 context,

toolkit/components/extensions/child/ext-userScripts.js

@@ -6,16 +6,6 @@
 
 "use strict";
 
-var USERSCRIPT_PREFNAME = "extensions.webextensions.userScripts.enabled";
-var USERSCRIPT_DISABLED_ERRORMSG = `userScripts APIs are currently experimental and must be enabled with the ${USERSCRIPT_PREFNAME} preference.`;
-
-XPCOMUtils.defineLazyPreferenceGetter(
-  this,
-  "userScriptsEnabled",
-  USERSCRIPT_PREFNAME,
-  false
-);
-
 // eslint-disable-next-line mozilla/reject-importGlobalProperties
 Cu.importGlobalProperties(["crypto", "TextEncoder"]);
 
@@ -170,10 +160,6 @@ this.userScripts = class extends ExtensionAPI {
     return {
       userScripts: {
         register(options) {
-          if (!userScriptsEnabled) {
-            throw new ExtensionError(USERSCRIPT_DISABLED_ERRORMSG);
-          }
-
           let scriptId = getUniqueId();
           return context.cloneScope.Promise.resolve().then(async () => {
             options.scriptId = scriptId;

toolkit/components/extensions/test/xpcshell/test_ext_userScripts.js

@@ -417,80 +417,6 @@ add_task(async function test_cached_userScript_on_document_start() {
   await extension.unload();
 });
 
-add_task(async function test_userScripts_pref_disabled() {
-  async function run_userScript_on_pref_disabled_test() {
-    async function background() {
-      let promise = (async () => {
-        await browser.userScripts.register({
-          js: [
-            {
-              code: "throw new Error('This userScripts should not be registered')",
-            },
-          ],
-          runAt: "document_start",
-          matches: ["<all_urls>"],
-        });
-      })();
-
-      await browser.test.assertRejects(
-        promise,
-        /userScripts APIs are currently experimental/,
-        "Got the expected error from userScripts.register when the userScripts API is disabled"
-      );
-
-      browser.test.sendMessage("background-page:done");
-    }
-
-    async function contentScript() {
-      let promise = (async () => {
-        browser.userScripts.onBeforeScript.addListener(() => {});
-      })();
-      await browser.test.assertRejects(
-        promise,
-        /userScripts APIs are currently experimental/,
-        "Got the expected error from userScripts.onBeforeScript when the userScripts API is disabled"
-      );
-
-      browser.test.sendMessage("content-script:done");
-    }
-
-    let extension = ExtensionTestUtils.loadExtension({
-      background,
-      manifest: {
-        permissions: ["http://*/*/file_sample.html"],
-        user_scripts: { api_script: "" },
-        content_scripts: [
-          {
-            matches: ["http://*/*/file_sample.html"],
-            js: ["content_script.js"],
-            run_at: "document_start",
-          },
-        ],
-      },
-      files: {
-        "content_script.js": contentScript,
-      },
-    });
-
-    await extension.startup();
-
-    await extension.awaitMessage("background-page:done");
-
-    let url = `${BASE_URL}/file_sample.html`;
-    let contentPage = await ExtensionTestUtils.loadContentPage(url);
-
-    await extension.awaitMessage("content-script:done");
-
-    await extension.unload();
-    await contentPage.close();
-  }
-
-  await runWithPrefs(
-    [["extensions.webextensions.userScripts.enabled", false]],
-    run_userScript_on_pref_disabled_test
-  );
-});
-
 // This test verify that userScripts.onBeforeScript API Event is not available without
 // a "user_scripts.api_script" property in the manifest.
 add_task(async function test_user_script_api_script_required() {