Revert "Bug 1969980 - part 3 - remove URL copied bookmark snackbar r=android-reviewers,android-l10n-reviewers,delphine,mavduevskiy" for causing lint failures @ SnackbarBindingTest.kt

This reverts commit 30815a2.

Author: Alexandru Marc

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/library/bookmarks/BookmarkController.kt

@@ -148,6 +148,7 @@ class DefaultBookmarkController(
     override fun handleCopyUrl(item: BookmarkNode) {
         val urlClipData = ClipData.newPlainText(item.url, item.url)
         clipboardManager?.setPrimaryClip(urlClipData)
+        showSnackbar(resources.getString(R.string.url_copied))
     }
 
     override fun handleBookmarkSharing(item: BookmarkNode) {

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/library/bookmarks/BookmarkFragment.kt

@@ -206,6 +206,9 @@ class BookmarkFragment : LibraryPageFragment<BookmarkNode>(), UserInteractionHan
                                             rootTitles = composeRootTitles(lifecycleHolder.context),
                                         ) ?: ""
                                     },
+                                    showUrlCopiedSnackbar = {
+                                        showSnackBarWithText(resources.getString(R.string.url_copied))
+                                    },
                                     getBrowsingMode = {
                                         lifecycleHolder.homeActivity.browsingModeManager.mode
                                     },

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/library/bookmarks/edit/EditBookmarkFragment.kt

@@ -154,6 +154,7 @@ class EditBookmarkFragment : Fragment(R.layout.fragment_edit_bookmark), MenuProv
                                             rootTitles = composeRootTitles(lifecycleHolder.context),
                                         ) ?: ""
                                     },
+                                    showUrlCopiedSnackbar = { },
                                     getBrowsingMode = {
                                         lifecycleHolder.homeActivity.browsingModeManager.mode
                                     },

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/library/bookmarks/ui/BookmarksMiddleware.kt

@@ -42,6 +42,7 @@ private const val WARN_OPEN_ALL_SIZE = 15
  * one or more bookmarks
  * @param showTabsTray Invoked after opening tabs from menus.
  * @param resolveFolderTitle Invoked to lookup user-friendly bookmark titles.
+ * @param showUrlCopiedSnackbar Invoked when a bookmark url is copied.
  * @param getBrowsingMode Invoked when retrieving the app's current [BrowsingMode].
  * @param openTab Invoked when opening a tab when a bookmark is clicked.
  * @param saveBookmarkSortOrder Invoked to persist the new sort order.
@@ -62,6 +63,7 @@ internal class BookmarksMiddleware(
     private val shareBookmarks: (List<BookmarkItem.Bookmark>) -> Unit = {},
     private val showTabsTray: (isPrivateMode: Boolean) -> Unit,
     private val resolveFolderTitle: (BookmarkNode) -> String,
+    private val showUrlCopiedSnackbar: () -> Unit,
     private val getBrowsingMode: () -> BrowsingMode,
     private val openTab: (url: String, openInNewTab: Boolean) -> Unit,
     private val saveBookmarkSortOrder: suspend (BookmarksListSortOrder) -> Unit,
@@ -497,6 +499,7 @@ internal class BookmarksMiddleware(
             is BookmarksListMenuAction.Bookmark.CopyClicked -> {
                 val urlClipData = ClipData.newPlainText(bookmark.url, bookmark.url)
                 clipboardManager?.setPrimaryClip(urlClipData)
+                showUrlCopiedSnackbar()
             }
 
             is BookmarksListMenuAction.Bookmark.ShareClicked -> {

mobile/android/fenix/app/src/main/res/values/strings.xml

@@ -2055,7 +2055,7 @@
     <!-- Tab collection deletion prompt dialog option to delete the collection -->
     <string name="tab_collection_dialog_positive">Delete</string>
     <!-- Message for copying the URL via long press on the toolbar -->
-    <string name="url_copied" tools:ignore="UnusedResources" moz:removedIn="142">URL copied</string>
+    <string name="url_copied">URL copied</string>
     <!-- Sample text for accessibility font size -->
     <string name="accessibility_text_size_sample_text_1">This is sample text. It is here to show how text will appear when you increase or decrease the size with this setting.</string>
     <!-- Summary for Accessibility Text Size Scaling Preference -->

mobile/android/fenix/app/src/test/java/org/mozilla/fenix/library/bookmarks/BookmarkControllerTest.kt

@@ -297,6 +297,21 @@ class BookmarkControllerTest {
         }
     }
 
+    @Test
+    fun `handleCopyUrl should copy bookmark url to clipboard and show a toast`() {
+        val urlCopiedMessage = context.getString(R.string.url_copied)
+
+        var showSnackbarInvoked = false
+        createController(
+            showSnackbar = {
+                assertEquals(urlCopiedMessage, it)
+                showSnackbarInvoked = true
+            },
+        ).handleCopyUrl(item)
+
+        assertTrue(showSnackbarInvoked)
+    }
+
     @Test
     fun `handleBookmarkSharing should navigate to the 'Share' fragment`() {
         val navDirectionsSlot = slot<NavDirections>()

mobile/android/fenix/app/src/test/java/org/mozilla/fenix/snackbar/SnackbarBindingTest.kt

@@ -504,6 +504,21 @@ class SnackbarBindingTest {
         assertEquals(SnackbarState.None, appStore.state.snackbarState)
     }
 
+    @Test
+    fun `WHEN the current URL is copied to clipboard THEN display a snackbar`() {
+        val binding = buildSnackbarBinding()
+        binding.start()
+
+        appStore.dispatch(URLCopiedToClipboard)
+        waitForStoreToSettle()
+
+        verify(snackbarDelegate).show(
+            text = testContext.getString(R.string.browser_toolbar_url_copied_to_clipboard_snackbar),
+            duration = LENGTH_LONG,
+        )
+        assertEquals(SnackbarState.None, appStore.state.snackbarState)
+    }
+
     @Test
     fun `WHEN download is failed THEN display a snackbar`() {
         val snackbarAction = argumentCaptor<((v: View) -> Unit)>()