Skip to content

Commit db5e76a

Browse files
committed
Bug 1987429 - Use reduced urlbar min-width for vertical tabs, and reduce window min-width accordingly. r=kcochrane,desktop-theme-reviewers,emilio
Differential Revision: https://phabricator.services.mozilla.com/D264090
1 parent ae99232 commit db5e76a

File tree

2 files changed

+31
-41
lines changed

2 files changed

+31
-41
lines changed

browser/themes/shared/browser-shared.css

Lines changed: 11 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,14 @@ body {
3636
}
3737

3838
:root {
39+
--window-min-width: 500px;
40+
/* Vertical tabs need extra room in the nav bar for window controls,
41+
drag space, and the sidebar button. */
42+
--window-min-width-increase-for-vertical-tabs: 197px;
43+
@media (-moz-platform: macos) {
44+
--window-min-width-increase-for-vertical-tabs: 135px;
45+
}
46+
3947
user-select: none;
4048
color-scheme: light dark;
4149
text-rendering: optimizeLegibility;
@@ -51,28 +59,17 @@ body {
5159
}
5260

5361
&:not([chromehidden~="toolbar"]) {
54-
min-width: 500px;
62+
min-width: var(--window-min-width);
5563
min-height: 120px;
5664

5765
/* stylelint-disable-next-line media-query-no-invalid */
5866
@media -moz-pref("sidebar.verticalTabs") {
59-
min-width: 732px;
67+
min-width: calc(var(--window-min-width) + var(--window-min-width-increase-for-vertical-tabs));
6068

6169
/* If the Content Analysis icon is showing, we don't
6270
want to collapse it, so make a little more room. */
6371
&[contentanalysisactive] {
64-
min-width: 768px;
65-
}
66-
67-
@media (-moz-platform: macos) {
68-
min-width: 670px;
69-
70-
/* If the Content Analysis icon is showing, we don't
71-
want to collapse it, so make a little more room. */
72-
/* stylelint-disable max-nesting-depth */
73-
&[contentanalysisactive] {
74-
min-width: 706px;
75-
}
72+
min-width: calc(var(--window-min-width) + var(--window-min-width-increase-for-vertical-tabs) + 36px);
7673
}
7774
}
7875
}

browser/themes/shared/urlbar-searchbar.css

Lines changed: 20 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -10,17 +10,32 @@
1010
--urlbar-margin-inline: 5px;
1111
--urlbar-padding-block: 4px;
1212

13+
@media (max-width: 770px) {
14+
--urlbar-container-min-width: 240px;
15+
}
16+
@media (max-width: 550px) {
17+
--urlbar-container-min-width: 176px;
18+
}
1319
&[taskbartab] {
1420
/* Taskbar tab windows are more size-constrained due to window controls
15-
being in the nav bar, so we use the not-yet-default value from below as
16-
if the trust panel was enabled. */
21+
being in the nav bar, so we use the smaller not-yet-default value from
22+
below as if the trust panel was enabled. */
1723
--urlbar-container-min-width: 275px;
1824
}
25+
/* Enabling the trust panel saves up to two icons in the front part of the
26+
address bar.
27+
Vertical tab mode is more size-constrained due to window controls being in
28+
the nav bar, so we use the smaller not-yet-default value as if the trust
29+
panel was enabled. */
1930
/* stylelint-disable-next-line media-query-no-invalid */
20-
@media -moz-pref("browser.urlbar.trustPanel.featureGate") {
21-
/* Enabling the trust panel saves up to two icons in the front part of the
22-
address bar. */
31+
@media -moz-pref("sidebar.verticalTabs") or -moz-pref("browser.urlbar.trustPanel.featureGate") {
2332
--urlbar-container-min-width: 275px;
33+
@media (max-width: 770px) {
34+
--urlbar-container-min-width: 205px;
35+
}
36+
@media (max-width: 550px) {
37+
--urlbar-container-min-width: 140px;
38+
}
2439
}
2540
}
2641

@@ -396,18 +411,6 @@
396411
}
397412

398413
@media (max-width: 770px) {
399-
#urlbar-container {
400-
width: calc(240px + 2 * (24px + 2 * var(--toolbarbutton-inner-padding)));
401-
}
402-
#nav-bar:is([downloadsbuttonshown], [unifiedextensionsbuttonshown]) #urlbar-container {
403-
width: calc(240px + 24px + 2 * var(--toolbarbutton-inner-padding));
404-
}
405-
#nav-bar[downloadsbuttonshown][unifiedextensionsbuttonshown] #urlbar-container {
406-
width: 240px;
407-
}
408-
:root[customizing] #urlbar-container {
409-
width: 245px;
410-
}
411414
#identity-icon-box {
412415
max-width: 80px;
413416
}
@@ -447,16 +450,6 @@
447450
}
448451

449452
@media (max-width: 550px) {
450-
#urlbar-container {
451-
width: calc(176px + 2 * (24px + 2 * var(--toolbarbutton-inner-padding)));
452-
}
453-
#nav-bar[downloadsbuttonshown] #urlbar-container,
454-
#nav-bar[unifiedextensionsbuttonshown] #urlbar-container {
455-
width: calc(176px + 24px + 2 * var(--toolbarbutton-inner-padding));
456-
}
457-
#nav-bar[downloadsbuttonshown][unifiedextensionsbuttonshown] #urlbar-container {
458-
width: 176px;
459-
}
460453
#identity-icon-box {
461454
max-width: 70px;
462455
}

0 commit comments

Comments
 (0)