Bug 1978208 - Serialize Color::InheritFromBodyQuirk. r=emilio.

nchevobbe · nchevobbe · commit ebc97f366a14 · 2025-07-19T22:12:12.000Z
Differential Revision: https://phabricator.services.mozilla.com/D257858
diff --git a/layout/inspector/tests/file_getMatchingCSSRules-default.html b/layout/inspector/tests/file_getMatchingCSSRules-default.html
@@ -1,6 +1,6 @@
-<!DOCTYPE html>
 <link rel="stylesheet" href="getMatchingCSSRules-1.css">
 <unknowntagname></unknowntagname>
 <img width=10 height=15>
 <div class="anim"></div>
 <div style="z-index: 1;"></div>
+<table></table>
diff --git a/layout/inspector/tests/test_getMatchingCSSRules.html b/layout/inspector/tests/test_getMatchingCSSRules.html
@@ -34,13 +34,20 @@
   return null;
 }
 
-function checkDeclaration(target, origin, props) {
+function checkDeclaration(doc, selector, origin, props) {
+  info(`Checking ${origin} declarations for element "${selector}"`);
   ok(!!props, "Should pass some properties to check");
+
+  const target = doc.querySelector(selector);
   let decl = getDeclarationWithOrigin(target, origin);
-  ok(!!decl, "Should find a declaration for " + origin);
-  info(decl.style.cssText);
-  for (let [k, v] of Object.entries(props)) {
-    is(decl.style[k], v, `Should see ${k}: ${v}`);
+  ok(!!decl, `Should find a ${origin} declaration for "${selector}"`);
+
+  const propsEntries = Object.entries(props);
+  is(decl.style.length, propsEntries.length, `Got expected number of ${origin} declarations for "${selector}"`);
+  for (let i = 0; i < decl.style.length; i++) {
+    const [name, value] = propsEntries[i] || [];
+    is(decl.style[i], name, `Should see "${name}" property on ${origin} declaration for "${selector}"`);
+    is(decl.style[name], value, `"${name}" has expected "${value}" value on ${origin} declaration for "${selector}"`);
   }
   let modificationThrew = false;
   try {
@@ -205,9 +212,10 @@
   {
     title: "Check pres hints",
     async run(doc, win) {
-      checkDeclaration(doc.querySelector("img"), "pres-hints", { width: "10px", height: "15px" });
-      checkDeclaration(doc.querySelector(".anim"), "animations", {zIndex: "1"});
-      checkDeclaration(doc.querySelector("[style]"), "style-attribute", {zIndex: "1"});
+      checkDeclaration(doc, "img", "pres-hints", { width: "10px", height: "15px", "aspect-ratio": "auto 10 / 15" });
+      checkDeclaration(doc, "table", "pres-hints", {color: "-moz-inherit-from-body-quirk"});
+      checkDeclaration(doc, ".anim", "animations", {"z-index": "1"});
+      checkDeclaration(doc, "[style]", "style-attribute", {"z-index": "1"});
       // TODO: transitions/SMIL are a bit more annoying to test.
     },
   }
diff --git a/servo/components/style/values/specified/color.rs b/servo/components/style/values/specified/color.rs
@@ -529,7 +529,7 @@ impl ToCss for Color {
             #[cfg(feature = "gecko")]
             Color::System(system) => system.to_css(dest),
             #[cfg(feature = "gecko")]
-            Color::InheritFromBodyQuirk => Ok(()),
+            Color::InheritFromBodyQuirk => dest.write_str("-moz-inherit-from-body-quirk"),
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -529,7 +529,7 @@ impl ToCss for Color {`
`529`	`529`	`#[cfg(feature = "gecko")]`
`530`	`530`	`Color::System(system) => system.to_css(dest),`
`531`	`531`	`#[cfg(feature = "gecko")]`
`532`		`- Color::InheritFromBodyQuirk => Ok(()),`
	`532`	`+ Color::InheritFromBodyQuirk => dest.write_str("-moz-inherit-from-body-quirk"),`
`533`	`533`	`}`
`534`	`534`	`}`
`535`	`535`	`}`