This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Issue #3265: Add support for "undo" functionality. #8449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is one test failing on |
Amejia481
approved these changes
Sep 21, 2020
components/browser/session/src/main/java/mozilla/components/browser/session/SessionManager.kt
Show resolved
Hide resolved
components/browser/session/src/main/java/mozilla/components/browser/session/SessionManager.kt
Show resolved
Hide resolved
...ents/browser/session/src/main/java/mozilla/components/browser/session/undo/UndoMiddleware.kt
Show resolved
Hide resolved
pocmo
force-pushed
the
undo-prototype
branch
2 times, most recently
from
4b5a6eb
to
427f8e3
Compare
This is not the fancy version yet since we still need to restore into SessionManager. Once it is gone and we rely on BrowserStore only, then we can make this better. However moving this functionality into AC now helps us: - It will be easier to migrate to a better undo functionality since this code is already in AC. - Other code can interact with the "undo" actions. For example "recently closed tabs" now will only contain a tab if the removal was not undone.
pocmo
force-pushed
the
undo-prototype
branch
from
427f8e3
to
82ce018
Compare
|
Added it to the changelog. |
pocmo
added
🛬 needs landing
pocmo
added a commit
to pocmo/fenix
that referenced
this pull request
Sep 22, 2020
This is not the super fancy version yet - since we still need to restore into SessionManager and haven't fully switched to BrowserStore yet. However AC having knowledge about "undo" and whether it was performed or not, will help us with features like "recently closed tabs". And once we can improve "undo", Fenix will get all the nice things automatically. Requires: mozilla-mobile/android-components#8449
pocmo
added a commit
to pocmo/fenix
that referenced
this pull request
Sep 22, 2020
This is not the super fancy version yet - since we still need to restore into SessionManager and haven't fully switched to BrowserStore yet. However AC having knowledge about "undo" and whether it was performed or not, will help us with features like "recently closed tabs". And once we can improve "undo", Fenix will get all the nice things automatically. Requires: mozilla-mobile/android-components#8449
pocmo
added a commit
to pocmo/fenix
that referenced
this pull request
Sep 22, 2020
This is not the super fancy version yet - since we still need to restore into SessionManager and haven't fully switched to BrowserStore yet. However AC having knowledge about "undo" and whether it was performed or not, will help us with features like "recently closed tabs". And once we can improve "undo", Fenix will get all the nice things automatically. Requires: mozilla-mobile/android-components#8449
3 tasks
ekager
pushed a commit
to pocmo/fenix
that referenced
this pull request
Sep 23, 2020
This is not the super fancy version yet - since we still need to restore into SessionManager and haven't fully switched to BrowserStore yet. However AC having knowledge about "undo" and whether it was performed or not, will help us with features like "recently closed tabs". And once we can improve "undo", Fenix will get all the nice things automatically. Requires: mozilla-mobile/android-components#8449
pocmo
added a commit
to pocmo/fenix
that referenced
this pull request
Sep 28, 2020
This is not the super fancy version yet - since we still need to restore into SessionManager and haven't fully switched to BrowserStore yet. However AC having knowledge about "undo" and whether it was performed or not, will help us with features like "recently closed tabs". And once we can improve "undo", Fenix will get all the nice things automatically. Requires: mozilla-mobile/android-components#8449
ekager
pushed a commit
to mozilla-mobile/fenix
that referenced
this pull request
Sep 28, 2020
This is not the super fancy version yet - since we still need to restore into SessionManager and haven't fully switched to BrowserStore yet. However AC having knowledge about "undo" and whether it was performed or not, will help us with features like "recently closed tabs". And once we can improve "undo", Fenix will get all the nice things automatically. Requires: mozilla-mobile/android-components#8449
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not the fancy version yet since we still need to restore into SessionManager. Once it is gone and
we rely on BrowserStore only, then we can make this better.
However moving this functionality into AC now helps us:
only contain a tab if the removal was not undone.
Pull Request checklist
After merge