Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Dependency substitution for android-components #1022

Closed
grigoryk opened this issue Mar 14, 2019 · 9 comments
Closed

Dependency substitution for android-components #1022

grigoryk opened this issue Mar 14, 2019 · 9 comments
Assignees
@grigoryk
Labels
E5 Estimation Point: about 5 days eng:build Build system, gradle, configuration P2 Upcoming release

Comments

@grigoryk
Copy link
Contributor

grigoryk commented Mar 14, 2019 •
edited by data-sync-user
Loading

This will allow us to easily develop against a local checkout of android-components.

Currently blocked on a-c moving to AndroidX (mozilla-mobile/android-components#842). Also, see similar r-b issue: mozilla-mobile/reference-browser#365

┆Issue is synchronized with this Jira Task
@grigoryk grigoryk added eng:build Build system, gradle, configuration 🙅 waiting Issues that are blocked or has dependencies that are not ready labels Mar 14, 2019
@grigoryk grigoryk mentioned this issue Mar 14, 2019
Closed
@vesta0 vesta0 added this to the MVP Backlog milestone Apr 4, 2019
@grigoryk
Copy link
Contributor Author

We should be mostly unblocked here. A-C needs to move to AndroidX but IIUC nothing is in the way of that.

@bifleming bifleming modified the milestones: MVP Backlog, Dev Stories Backlog May 2, 2019
@sblatz
Copy link
Contributor

sblatz commented Jul 15, 2019

@grigoryk is this still waiting on anything?

@boek boek removed this from the Dev Stories Backlog milestone Jul 17, 2019
@sblatz
Copy link
Contributor

sblatz commented Aug 16, 2019 •
edited
Loading

I think this is covered by using mavenLocal: https://mozac.org/contributing/testing-components-inside-app.

Please re-open if I'm incorrect!
I was incorrect 😂

@sblatz sblatz closed this as completed Aug 16, 2019
@sblatz sblatz reopened this Aug 16, 2019
@grigoryk
Copy link
Contributor Author

Here are pretty precise instructions on what needs to happen here: mozilla-mobile/reference-browser#365 (comment)

Nothing should be blocking this work, just needs to be tested.

@grigoryk grigoryk removed the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Aug 16, 2019
@sblatz sblatz added the P2 Upcoming release label Sep 24, 2019
@grigoryk
Copy link
Contributor Author

We've had a very traumatic past few weeks trying to do tight iterations across three levels of the stack (a-s -> a-c -> fenix), and not having this done yet has been such a pain. So let's bump this up in priority.

@grigoryk grigoryk removed the P2 Upcoming release label Sep 27, 2019
@grigoryk
Copy link
Contributor Author

Actually, I don't know what Fenix labels really mean, so I'll re-add it. In any case, this will be done as part of an a-c sprint.

@grigoryk grigoryk added the P2 Upcoming release label Sep 27, 2019
@pocmo
Copy link
Contributor

pocmo commented Sep 27, 2019 •
edited
Loading

@grigoryk: @jonalmeida and I both tried that in RB (earlier draft: mozilla-mobile/reference-browser#815) and the result has been horrible. Mostly because:

  • You can't get rid of it anymore. Android Studio completely ignores if you remove/reset the substitution.
  • It will also do the reverse and add all the app projects into the AC project which has been confusing and unexpected.

@Amejia481 Amejia481 added the E5 Estimation Point: about 5 days label Sep 30, 2019
grigoryk pushed a commit to grigoryk/fenix that referenced this issue Oct 4, 2019
Closes mozilla-mobile#1022: Auto-publication workflow for android-com…
477f17b 
…ponent

This patch enabled support for an auto-publication workflow for android-components.

It automates a common pattern seen in local development:

Old way:
- after every change in a-c, publish it locally with a unique version (bumping it manually)
- manually modify Fenix to consume a custom version of a-c from a mavenLocal repository

New way:
- set a flag in fenix's local.properties to enable auto-publication
- run Fenix builds after making changes to a-c. Changes in a-c will be automatically picked up.

Note that no changes are necessary to any Fenix files other than a single flag in local.properties.
Manually bumping android-components version is also not necessary.
grigoryk pushed a commit to grigoryk/fenix that referenced this issue Oct 4, 2019
Closes mozilla-mobile#1022: Auto-publication workflow for android-com…
6303624 
…ponent

This patch enabled support for an auto-publication workflow for android-components.

It automates a common pattern seen in local development:

Old way:
- after every change in a-c, publish it locally with a unique version (bumping it manually)
- manually modify Fenix to consume a custom version of a-c from a mavenLocal repository

New way:
- set a flag in fenix's local.properties to enable auto-publication
- run Fenix builds after making changes to a-c. Changes in a-c will be automatically picked up.

Note that no changes are necessary to any Fenix files other than a single flag in local.properties.
Manually bumping android-components version is also not necessary.
@grigoryk
Copy link
Contributor Author

grigoryk commented Oct 4, 2019

@pocmo i've ran into the same behaviour, and couldn't work around it. So instead went for automating a local publication workflow.

@pocmo pocmo mentioned this issue Oct 25, 2019
Closed
@msc94
Copy link

msc94 commented Dec 30, 2019

I think this does not work for windows, since you have to call "gradlew.bat", not "gradle".

@gabrielluong gabrielluong mentioned this issue Mar 24, 2020
Merged
2 tasks
@data-sync-user data-sync-user changed the title Dependency substitution for android-components FNX2-15803 ⁃ Dependency substitution for android-components Jul 30, 2020
@data-sync-user data-sync-user changed the title FNX2-15803 ⁃ Dependency substitution for android-components FNX3-13736 ⁃ Dependency substitution for android-components Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX3-13736 ⁃ Dependency substitution for android-components FNX-4726 ⁃ Dependency substitution for android-components Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX-4726 ⁃ Dependency substitution for android-components FNX2-15803 ⁃ Dependency substitution for android-components Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX2-15803 ⁃ Dependency substitution for android-components Dependency substitution for android-components May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@grigoryk grigoryk

Labels
E5 Estimation Point: about 5 days eng:build Build system, gradle, configuration P2 Upcoming release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@pocmo @grigoryk @Amejia481 @boek @sblatz @msc94 @vesta0 @bifleming @data-sync-user