Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug][a11y] Custom ETP settings height should be increased to 48dp or larger #10656

Closed
sflorean opened this issue May 14, 2020 · 1 comment
Closed

[Bug][a11y] Custom ETP settings height should be increased to 48dp or larger #10656

sflorean opened this issue May 14, 2020 · 1 comment
Assignees
@mcarare
Labels
access Accessibility: Talkback, HW keyboard/mouse, braile display etc. b:etp Issues caused by enhanced tracking protection 🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified P2 Upcoming release S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist

Comments

@sflorean
Copy link
Contributor

sflorean commented May 14, 2020 •
edited by data-sync-user
Loading

Prerequisites

Make sure you have Google Accessibility Scanner installed.

Steps to reproduce

  1. Go to Settings-> Enhanced Tracking protection -> Custom.
  2. Scan the page.

Expected behavior

There are no suggestions to make any changes.

Actual behavior

For "Cookies", "Tracking content", "Cryptominers" and "Fingerprinters" suggestions are made that the height to be increased from 44 to 48 dp.

Device information

  • Android device: Samsung Galaxy Note 10 (Android 10).
  • Fenix version: 76.0.0-beta.1, Nightly 5/14.

ScreenshotUNITO-UNDERSCORE!20200514-183453!UNITO-UNDERSCORE!Accessibility Scanner!

┆Issue is synchronized with this Jira Task
@sflorean sflorean added 🐞 bug Crashes, Something isn't working, .. access Accessibility: Talkback, HW keyboard/mouse, braile display etc. b:etp Issues caused by enhanced tracking protection labels May 14, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label May 14, 2020
@sflorean sflorean added S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist and removed needs:triage Issue needs triage labels May 14, 2020
@mcarare mcarare self-assigned this May 15, 2020
mcarare added a commit to mcarare/fenix that referenced this issue May 15, 2020
@mcarare
For mozilla-mobile#10656: Adjust etp checkbox dimensions for a11y.
3e7f9f4
mcarare added a commit that referenced this issue May 15, 2020
@mcarare
For #10656: Adjust etp checkbox dimensions for a11y.
b244fd5
@asadotzler asadotzler added the P2 Upcoming release label May 17, 2020
@liuche liuche mentioned this issue May 19, 2020
Closed
32 tasks
@mcarare mcarare added the eng:qa:needed QA Needed label May 26, 2020
@ebalazs-sv
Copy link

Verified as fixed on the latest Fenix Nightly Build 21470624, from 5/26, with Nexus 5 (Android 6.0.1), Motorola Moto G6 (Android 8), Pixel 2 (Android 9).

There are no suggestions for "Cookies", "Tracking content", "Cryptominers" and "Fingerprinters".

I will remove the qa:needed label. Thanks!

@ebalazs-sv ebalazs-sv added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels May 26, 2020
@data-sync-user data-sync-user changed the title [Bug][a11y] Custom ETP settings height should be increased to 48dp or larger FNX2-16074 ⁃ [Bug][a11y] Custom ETP settings height should be increased to 48dp or larger Jul 31, 2020
@data-sync-user data-sync-user changed the title FNX2-16074 ⁃ [Bug][a11y] Custom ETP settings height should be increased to 48dp or larger FNX-4451 ⁃ [Bug][a11y] Custom ETP settings height should be increased to 48dp or larger Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX-4451 ⁃ [Bug][a11y] Custom ETP settings height should be increased to 48dp or larger FNX3-14055 ⁃ [Bug][a11y] Custom ETP settings height should be increased to 48dp or larger Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX3-14055 ⁃ [Bug][a11y] Custom ETP settings height should be increased to 48dp or larger FNX2-16074 ⁃ [Bug][a11y] Custom ETP settings height should be increased to 48dp or larger Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX2-16074 ⁃ [Bug][a11y] Custom ETP settings height should be increased to 48dp or larger FNX-4451 ⁃ [Bug][a11y] Custom ETP settings height should be increased to 48dp or larger Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-4451 ⁃ [Bug][a11y] Custom ETP settings height should be increased to 48dp or larger [Bug][a11y] Custom ETP settings height should be increased to 48dp or larger May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcarare mcarare

Labels
access Accessibility: Talkback, HW keyboard/mouse, braile display etc. b:etp Issues caused by enhanced tracking protection 🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified P2 Upcoming release S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@asadotzler @ebalazs-sv @mcarare @data-sync-user @sflorean