Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Visual design of "Delete browsing data" should match "Delete browsing data on quit" #11665

Closed
brampitoyo opened this issue Jun 17, 2020 · 1 comment
Closed

[Bug] Visual design of "Delete browsing data" should match "Delete browsing data on quit" #11665

brampitoyo opened this issue Jun 17, 2020 · 1 comment
Assignees
@mcarare
Labels
🐞 bug Crashes, Something isn't working, .. E2 Estimation Point: easy, half a day to 2 days eng:qa:verified QA Verified eng:ready Ready for engineering Feature:Settings needs:triage Issue needs triage

Comments

@brampitoyo
Copy link

brampitoyo commented Jun 17, 2020 •
edited by data-sync-user
Loading

@mcarare wrote on #9229 (comment)

I noticed that there are some noticeable inconsistencies between the two screens (option name, option description font- see below) and a strange large space on the first screen.

The changes that we should make is outlined below.

Delete browsing data on quit

  • Browsing history → Browsing history and site data
  • Reduce space between toggle and checkbox group. The amount of space should be identical to Settings → Enhanced Tracking Protection toggle, and the radio buttons below it.

Delete browsing data

  • Caption font should be Inter (or Roboto) instead of Metropolis

On both pages

  • Icon and text padding should be identical to the value used on the Settings main page

Revised mockups that shows the changes above

┆Issue is synchronized with this Jira Task
@brampitoyo brampitoyo added 🐞 bug Crashes, Something isn't working, .. eng:ready Ready for engineering ux:visual-design Feature:Settings labels Jun 17, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Jun 17, 2020
@mcarare mcarare added the E2 Estimation Point: easy, half a day to 2 days label Jun 17, 2020
mcarare added a commit to mcarare/fenix that referenced this issue Jun 17, 2020
@mcarare
For mozilla-mobile#11665: Adjust visual design for delete browsing da…
ea3fd44 
…ta screens.
mcarare added a commit to mcarare/fenix that referenced this issue Jun 17, 2020
@mcarare
For mozilla-mobile#11665: Update UI tests.
d06425a
mcarare added a commit to mcarare/fenix that referenced this issue Jun 18, 2020
@mcarare
For mozilla-mobile#11665: Update UI tests.
7d21059
mcarare added a commit to mcarare/fenix that referenced this issue Jun 18, 2020
@mcarare
For mozilla-mobile#11665: Adjust visual design for delete browsing da…
38b8f43 
…ta screens.
mcarare added a commit to mcarare/fenix that referenced this issue Jun 18, 2020
@mcarare
For mozilla-mobile#11665: Adjust visual design for delete browsing da…
6c827bd 
…ta screens.
mcarare added a commit to mcarare/fenix that referenced this issue Jun 18, 2020
@mcarare
For mozilla-mobile#11665: Update UI tests.
e470698
BranescuMihai pushed a commit that referenced this issue Jun 19, 2020
@mcarare @BranescuMihai
For #11665: Adjust visual design for delete browsing data screens.
e7bc266
BranescuMihai pushed a commit that referenced this issue Jun 19, 2020
@mcarare @BranescuMihai
For #11665: Update UI tests.
f4ebe39
@hkaancaliskan hkaancaliskan mentioned this issue Jun 19, 2020
Closed
@mcarare mcarare added the eng:qa:needed QA Needed label Jun 20, 2020
@AndiAJ
Copy link
Collaborator

AndiAJ commented Jun 22, 2020

Hi, verified as fixed on the latest Nightly Build 200622 from 6/22 using the following devices:
• Google Pixel 3a (Android 10)
• Huawei Mate 20 Lite (Android 9)
• OnePlus A3 (Android 6.0.1)

► Screenshots
rsz_screenshot_20200622-094851

@AndiAJ AndiAJ closed this as completed Jun 22, 2020
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jun 22, 2020
@liuche liuche mentioned this issue Jun 27, 2020
Closed
12 tasks
@data-sync-user data-sync-user changed the title [Bug] Visual design of "Delete browsing data" should match "Delete browsing data on quit" FNX2-16605 ⁃ [Bug] Visual design of "Delete browsing data" should match "Delete browsing data on quit" Aug 1, 2020
@data-sync-user data-sync-user changed the title FNX2-16605 ⁃ [Bug] Visual design of "Delete browsing data" should match "Delete browsing data on quit" FNX3-14807 ⁃ [Bug] Visual design of "Delete browsing data" should match "Delete browsing data on quit" Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-14807 ⁃ [Bug] Visual design of "Delete browsing data" should match "Delete browsing data on quit" FNX-12642 ⁃ [Bug] Visual design of "Delete browsing data" should match "Delete browsing data on quit" Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-12642 ⁃ [Bug] Visual design of "Delete browsing data" should match "Delete browsing data on quit" FNX2-16605 ⁃ [Bug] Visual design of "Delete browsing data" should match "Delete browsing data on quit" Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX2-16605 ⁃ [Bug] Visual design of "Delete browsing data" should match "Delete browsing data on quit" [Bug] Visual design of "Delete browsing data" should match "Delete browsing data on quit" May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcarare mcarare

Labels
🐞 bug Crashes, Something isn't working, .. E2 Estimation Point: easy, half a day to 2 days eng:qa:verified QA Verified eng:ready Ready for engineering Feature:Settings needs:triage Issue needs triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@brampitoyo @mcarare @AndiAJ @data-sync-user