[Bug] Open in app banner

[topotropic]

Steps to reproduce

• Use a fresh install or clear the cache
• Open Firefox and search for something with Google
• "Open in app" banner appears on google search result page
• When I turn "Open in app" on and try the search again, nothing happens, no app opens

Expected behavior

I don't see a banner

Actual behavior

I see a banner on top of my google search results

Device information

• Android device: ?
• Fenix version: ?

┆Issue is synchronized with this Jira Task

[liuche]

This should be solvable in AC, we already have some ability to exclude the banner for some sites.

[liuche]

cc @rocketsroger we should do this bc it affects search.

[rocketsroger]

@topotropic is this still reproducible? I can see banner is other sites such as twitter but not in google search.

[rocketsroger]

While debugging I noticed that a simpler if condition can make maintenance easier. Also added some tests. Still cannot reproduce the issue.

[rocketsroger]

I'll close this issue since I can't reproduce it. I've cleaned up the if condition so it's now easier to see that unless there is an app (non browser) that registers to open google.com, the app banner should now show in the search page. Please reopen if reproducible.