Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

HTTPS-Only Mode #16952

Closed
Amejia481 opened this issue Dec 9, 2020 · 18 comments · Fixed by #24095
Closed

HTTPS-Only Mode #16952

Amejia481 opened this issue Dec 9, 2020 · 18 comments · Fixed by #24095
Assignees
Labels
Milestone

Comments

@Amejia481
Copy link
Contributor

Amejia481 commented Dec 9, 2020

User Story

Dependencies

  • GeckoView bug.

Acceptance Criteria

  • When I navigate to any site, the HTTPS version should be always served

The https-only error page may appear if there is another error encountered even if the target redirected to a https page - https://bugzilla.mozilla.org/show_bug.cgi?id=1759114

┆Issue is synchronized with this Jira Task

@github-actions github-actions bot added the needs:triage Issue needs triage label Dec 9, 2020
@Amejia481
Copy link
Contributor Author

This functionality was already introduced in desktop 83 and we want to start gathering all the dependencies needed for the feature.

cc: @vesta0

@saschanaz
Copy link

Duplicate of #14682 and of #12347

@Amejia481
Copy link
Contributor Author

@saschanaz I think we could close the other ones are they are feature requests, this is an user story issue and it will be used for creating all the UI/UX and engineering tasks :)

@kbrosnan
Copy link
Contributor

This needs error page work as well. We need to figure out a way to provide the escape hatch button to http. Need to sort out how the error page will work with PWAs. Need to think about how the escape hatch persistence will work with things like private browsing.

@kbrosnan kbrosnan added the feature request 🌟 New functionality and improvements label Dec 10, 2020
@ghost
Copy link

ghost commented Jan 12, 2021

really needed feature

@Amejia481 Amejia481 added this to New Features/Functions (top 20) in Android Team Backlog Staging Board Jan 12, 2021
@Amejia481 Amejia481 added 🙅 waiting Issues that are blocked or has dependencies that are not ready needs:UX-review labels Jan 12, 2021
@apbitner apbitner added needs:UX-investigation Issues where UX needs to define or scope a solution or determine feasibility and removed needs:UX-review labels Jan 13, 2021
@julian-alarcon
Copy link

As bug in Gecko view was already closed, it should be a priority.

@cschanaj
Copy link
Contributor

cschanaj commented Apr 15, 2021

EFF has announced that HTTPS Everywhere is expected to reach its EOL by the end of 2021. HTTPS-Only Mode on Fenix could be a preferred alternatives to HTTPS Everywhere EASE mode to enforce HTTPS secure connections only and block HTTP connections on insecure mobile networks. I sincerely hope this feature can be prioritized.

Related: EFForg/https-everywhere#20048 cc @zoracon

@Amejia481
Copy link
Contributor Author

@brampitoyo just to let you know that this is something that we want to add UI on Fenix and Focus, could you help us with the designs ? cc @amedyne

@brampitoyo
Copy link

@Amejia481 @amedyne I would say that Focus should go HTTPS-Only by default, without showing any UI. This way, our users will get automatic browsing security without any hassle.

But I wonder whether there’s any side effect to this decision? I’d love to hear your feedback.

I will bring this up in the next UI Catchup meeting with @channingcarter, as well.

@cadeyrn
Copy link
Contributor

cadeyrn commented Aug 26, 2021

@brampitoyo

But I wonder whether there’s any side effect to this decision?

It's already on by default in Focus (or Fenix in private mode as well as in the desktop Firefox in private mode) and not having an UI already causes issues in Focus: mozilla-mobile/focus-android#5199

@Amejia481
Copy link
Contributor Author

Amejia481 commented Aug 26, 2021

@brampitoyo as @cadeyrn mentioned Focus and Fenix are already using HTTPS-Only mode (in private browsing) by default without UI and the only side effect that we are experiencing is mozilla-mobile/focus-android#5199 as @cadeyrn mentioned, without the UI users don't have a way indicate that they want to proceed to navigate to HTTP sites in edge cases like mozilla-mobile/focus-android#5199.

@amedyne
Copy link
Contributor

amedyne commented Aug 26, 2021

@brampitoyo desktop has provided options for users to change the default values. You can refer to them here. We can discuss further what we can do for Focus (and Fenix).

@brampitoyo
Copy link

@amedyne For Fenix, I think we can safely implement the same UI as desktop: with identical explanation, radio buttons, and exceptions list. (Let’s consult @betsymi at Content Design first, though!)

Do you know what desktop’s default value is? On Fenix, I feel pretty safe toggling Enable in private windows only to ON, but it’s best to follow desktop’s default value and not risk broken sites.


As for Focus, it’s clear that this feature should be toggled Enable, and it should only have two radio buttons: Enable and Don’t enable. Focus is always private, and there’s no need for a third radio button.

What will need more thinking is whether Focus should also ship with an exceptions list. I lean towards a “no”, so Focus stays slim and doesn’t maintain yet another list. If a site doesn’t work properly on a secondary browser like Focus, opening it on a primary browser like Firefox is an option.

@saschanaz
Copy link

saschanaz commented Sep 4, 2021

@yoasif
Copy link
Contributor

yoasif commented Sep 28, 2021

This is parity-chrome as of Chrome 94. HTTPS Everywhere is also being retired: https://www.eff.org/deeplinks/2021/09/https-actually-everywhere

@Amejia481 Amejia481 added E8 Estimation Point: about 8 days and removed 🙅 waiting Issues that are blocked or has dependencies that are not ready labels Dec 7, 2021
@Amejia481
Copy link
Contributor Author

Just for reference we need the same engineering tasks as the focus counterpart mozilla-mobile/focus-android#5365 (comment)

@sheikh-azharuddin
Copy link

Just a suggestion..instead of adding this on the main setting menu which will increase the list..why not add a sub menu under privacy and security called "network security", inside this you can add https only mode and DNS server like cloudflare/nextdns/custom like desktop variant ..., majority of chromium browser has this setting..maybe it can be added in future but yes submenu will create a placeholder

mergify bot pushed a commit that referenced this issue Mar 29, 2022
Default will be disabled with users having the possibility to enable this from
a new setting in the `Privacy and security` section.
If enabled then by default this force https for all tabs with the option for
users to switch to forcing https only on private tabs.
mergify bot pushed a commit that referenced this issue Mar 29, 2022
Pending refactoring following the addition of a new setting, work to be done in
#24495
@gabrielluong gabrielluong added this to the 100 milestone Mar 29, 2022
@gabrielluong gabrielluong added eng:qa:needed QA Needed and removed feature request 🌟 New functionality and improvements needs:UX-investigation Issues where UX needs to define or scope a solution or determine feasibility labels Mar 29, 2022
@SoftVision-LorandJanos
Copy link

Verified as fixed on the latest Nightly 100.0a1 (2022-03-30) build.
Devices used:

  • Google Pixel 4 (Android 11).
  • Oppo Reno 6 (Android 12).
    Closing the ticket as fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
No open projects
Android Team Backlog Staging Board
New Features/Functions (top 20)
Development

Successfully merging a pull request may close this issue.