Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Https-only mode error page #23337

Closed
Mugurell opened this issue Jan 20, 2022 · 7 comments
Closed

Https-only mode error page #23337

Mugurell opened this issue Jan 20, 2022 · 7 comments
Assignees
Milestone

Comments

@Mugurell
Copy link
Contributor

Mugurell commented Jan 20, 2022

Following #16952 we need to update the default error page to something offering more context and probably a "Continue to HTTP site" button similar to what's been done on Focus.

Default error page Focus error page
image image

We could have a different error page offering more context, as suggested in mozilla-mobile/android-components#11306.

Asking UX about the design and text to use.
cc @topotropic


Fenix design is available at https://www.figma.com/file/RyIADLmC3B0BIS9jSiAti3/?node-id=1238%3A63076

image

┆Issue is synchronized with this Jira Task

@Mugurell Mugurell added Feature:Privacy&Security needs:UX-investigation Issues where UX needs to define or scope a solution or determine feasibility labels Jan 20, 2022
@github-actions github-actions bot added the needs:triage Issue needs triage label Jan 20, 2022
@Mugurell
Copy link
Contributor Author

@Amejia481 Regarding the "continue" button which should store an exception from erroring on http I think the exceptions should be handled by GeckoView to allow for a smooth UX that would load the http webpage without any hiccup.
I imagine rather GV/Gecko seeing that the webpage is using http and deciding whether to send an error or continue to load the webpage anyway.
The API Focus uses - document.reloadWithHttpsOnlyException() doesn't seem useful on Fenix.
Thoughts?

@Amejia481
Copy link
Contributor

@Amejia481 Regarding the "continue" button which should store an exception from erroring on http I think the exceptions should be handled by GeckoView to allow for a smooth UX that would load the http webpage without any hiccup.
I imagine rather GV/Gecko seeing that the webpage is using http and deciding whether to send an error or continue to load the webpage anyway.

Yes, agree, I'm not completely sure if this API is already implemented on GV, maybe @agi could help to clarify, maybe the could expose the same API that desktop is using.

The API Focus uses - document.reloadWithHttpsOnlyException() doesn't seem useful on Fenix.
Thoughts?

I think we could use it, as we'll only need the API for storing the exemption to run before that, maybe the API is also on JS and we just need to expose reading the exception on GV.

@agi
Copy link
Contributor

agi commented Jan 21, 2022

I'm not sure I'm following, what's the problem with reloadWithHttpsOnlyException? If you call that after the user taps on "Continue to HTTP site" the pageload will go through using HTTP. What's the piece of functionality that's missing?

@Amejia481
Copy link
Contributor

In desktop, we after users indicate that they want to allow an HTTPS to load the page, they can persist that decision . The API we are thinking should be on the GV side is the storage part for this exceptions, I'm not sure if GV could expose the same storage that desktop is using.

@Mugurell
Copy link
Contributor Author

Mugurell commented Feb 1, 2022

I'm not sure I'm following, what's the problem with reloadWithHttpsOnlyException? If you call that after the user taps on "Continue to HTTP site" the pageload will go through using HTTP. What's the piece of functionality that's missing?

@agi
When users first click "continue.." we'd want to:

  • store the http exception for that specific website
  • use reloadWithHttpsOnlyException to reload the webpage and access it through http

 
When users access a previous page for which they tapped "continue.." we'd want to:

  • just load the webpage, in one go, withough GV erroring and then us calling reload - like it would happen if we persist the exception in the client.

If GV would persist the http exception it could know to not send us the error and load the http page without us having to reload it so this will be totally transparent to the user.

@agi
Copy link
Contributor

agi commented Feb 1, 2022

Makes sense! Opened https://bugzilla.mozilla.org/show_bug.cgi?id=1753099

@Mugurell Mugurell self-assigned this Mar 29, 2022
@Mugurell Mugurell removed the needs:UX-investigation Issues where UX needs to define or scope a solution or determine feasibility label Mar 29, 2022
@Mugurell Mugurell added the eng:qa:needed QA Needed label Mar 30, 2022
@Mugurell Mugurell added this to the 100 milestone Mar 30, 2022
@Mugurell Mugurell removed the needs:triage Issue needs triage label Mar 30, 2022
@SoftVision-LorandJanos
Copy link

Verified as fixed on the latest Nightly 100.0a1 (2022-03-30) build.
Devices used:

  • Google Pixel 4 (Android 11).
  • Oppo Reno 6 (Android 12).

Closing the ticket as fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants