Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Update disabled ui test settingsPrivacyItemsTest #24495

Closed
Mugurell opened this issue Mar 29, 2022 · 2 comments
Closed

Update disabled ui test settingsPrivacyItemsTest #24495

Mugurell opened this issue Mar 29, 2022 · 2 comments
Assignees
@AndiAJ
Labels
eng:disabled-test For any test that has been disabled eng:ui-test UI Tests

Comments

@Mugurell
Copy link
Contributor

Mugurell commented Mar 29, 2022 •
edited by data-sync-user
Loading

Test was disabled following #16952 which added new setting in the "Privacy and security" section: "HTTPS-Only Mode".

Some changes needed:

  • verify the new setting title and summary in the general settings screen
  • verify the details shown when opening the new "HTTPS-Only Mode" settings screen
  • update test to avoid the current androidx.test.espresso.AmbiguousViewMatcherException: 'with text: is "Off"' matches multiple views in the hierarchy. exception.

┆Issue is synchronized with this Jira Task
@github-actions github-actions bot added the needs:triage Issue needs triage label Mar 29, 2022
@Mugurell
Copy link
Contributor Author

cc @sv-ohorvath

@sv-ohorvath sv-ohorvath added eng:ui-test UI Tests eng:disabled-test For any test that has been disabled and removed needs:triage Issue needs triage labels Mar 29, 2022
@Mugurell Mugurell mentioned this issue Mar 29, 2022
Merged
3 tasks
mergify bot pushed a commit that referenced this issue Mar 29, 2022
@Mugurell @mergify
For #16952 - Temporarily disable settingsPrivacyItemsTest ui test
dc87226 
Pending refactoring following the addition of a new setting, work to be done in
#24495
@AndiAJ AndiAJ mentioned this issue Apr 11, 2022
Merged
3 tasks
mergify bot added a commit that referenced this issue Apr 12, 2022
@AndiAJ @mergify
For #24495 fix and re-enable settingsPrivacyItemsTest UI test. (#24705)
8c42f7f 
* Fix delete browsing data on quit ambiguous matcher

* Add missing HTTPS-Only Mode assertions to settingsPrivacyItemsTest UI test

* SettingsRobot refactoring work

Co-authored-by: AndiAJ <andiaj@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@AndiAJ
Copy link
Collaborator

AndiAJ commented Apr 13, 2022

Fixed in #24705 added the verification for "HTTPS-Only Mode" in "Privacy and security" section and fixed the AmbiguousViewMatcherException

The details when opening the "HTTPS-Only Mode" will be covered in a different test

@AndiAJ AndiAJ closed this as completed Apr 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AndiAJ AndiAJ

Labels
eng:disabled-test For any test that has been disabled eng:ui-test UI Tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sv-ohorvath @Mugurell @AndiAJ