Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Re-add multi-select support on browser tray lists #18443

Closed
jonalmeida opened this issue Mar 11, 2021 · 0 comments · Fixed by #18655
Closed

Re-add multi-select support on browser tray lists #18443

jonalmeida opened this issue Mar 11, 2021 · 0 comments · Fixed by #18655
Assignees
@codrut-topliceanu
Labels
E3 Estimation Point: average, 2 - 3 days Feature:SyncTabs Sync tabs Feature:Tabs MR1 Issues that are needed for the MR1 2021 release.
Milestone
89

Comments

@jonalmeida
Copy link
Contributor

jonalmeida commented Mar 11, 2021 •
edited by data-sync-user
Loading

We should rely heavily on the recyclerview-selection library as much as possible.

A short investigation was done in #14969 (comment) :

I'm glad that you were able to get the RecyclerView selection working! And you can trigger it externally via a button?

Yes, there's an API that let's you define the single-click property. You can see this in the Sunflower demo app which uses the selection library that we can modify with the patch below in the adapter. We would obviously do this dynamically depending on the state we have in the store.

┆Issue is synchronized with this Jira Task
@jonalmeida jonalmeida added Feature:SyncTabs Sync tabs MR1 Issues that are needed for the MR1 2021 release. E3 Estimation Point: average, 2 - 3 days labels Mar 11, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Mar 11, 2021
@jonalmeida jonalmeida self-assigned this Mar 11, 2021
@jonalmeida jonalmeida removed their assignment Mar 17, 2021
@jonalmeida jonalmeida removed the needs:triage Issue needs triage label Mar 17, 2021
@codrut-topliceanu codrut-topliceanu self-assigned this Mar 17, 2021
@jonalmeida jonalmeida mentioned this issue Mar 18, 2021
Closed
jonalmeida added a commit to jonalmeida/fenix that referenced this issue Mar 25, 2021
@jonalmeida
Close mozilla-mobile#18443: Use recyclerview-selection for multi-sele…
575a8c3 
…ct mode in tray

Add multi-select mode to the BrowserTabsAdapter. It has the
functionality to:
 - Enable multi-select mode on long-press.
 - Enable multi-select mode when changed by an external function.
 - Only works for normal tabs (as we currently have it).

Co-authored-by: "codrut.topliceanu" <codrut.topliceanu@softvision.ro>
jonalmeida added a commit to jonalmeida/fenix that referenced this issue Mar 26, 2021
@jonalmeida
Close mozilla-mobile#18443: Use recyclerview-selection for multi-sele…
d9bcb22 
…ct mode in tray

Add multi-select mode to the BrowserTabsAdapter. It has the
functionality to:
 - Enable multi-select mode on long-press.
 - Enable multi-select mode when changed by an external function.
 - Only works for normal tabs (as we currently have it).

Co-authored-by: "codrut.topliceanu" <codrut.topliceanu@softvision.ro>
jonalmeida added a commit to jonalmeida/fenix that referenced this issue Mar 26, 2021
@jonalmeida
Issue mozilla-mobile#18443: Fix changes between grid/list viewholders
53fa345
jonalmeida added a commit to jonalmeida/fenix that referenced this issue Mar 26, 2021
@jonalmeida
Issue mozilla-mobile#18443: Move viewholders to separate files and pa…
f28dff9 
…ckage
@jonalmeida jonalmeida mentioned this issue Mar 26, 2021
Merged
3 tasks
jonalmeida added a commit to jonalmeida/fenix that referenced this issue Mar 26, 2021
@jonalmeida
Issue mozilla-mobile#18443: Fix changes between grid/list viewholders
82c2bce
jonalmeida added a commit to jonalmeida/fenix that referenced this issue Mar 26, 2021
@jonalmeida
Issue mozilla-mobile#18443: Move viewholders to separate files and pa…
fdfb93a 
…ckage
jonalmeida added a commit that referenced this issue Mar 26, 2021
@jonalmeida
Close #18443: Use recyclerview-selection for multi-select mode in tray
9ce4ada 
Add multi-select mode to the BrowserTabsAdapter. It has the
functionality to:
 - Enable multi-select mode on long-press.
 - Enable multi-select mode when changed by an external function.
 - Only works for normal tabs (as we currently have it).

Co-authored-by: "codrut.topliceanu" <codrut.topliceanu@softvision.ro>
jonalmeida added a commit that referenced this issue Mar 26, 2021
@jonalmeida
Issue #18443: Fix changes between grid/list viewholders
917783a
jonalmeida added a commit that referenced this issue Mar 26, 2021
@jonalmeida
Issue #18443: Move viewholders to separate files and package
26c176a
@gabrielluong gabrielluong added this to the 89 milestone Mar 30, 2021
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 5, 2021
@jonalmeida @pkirakosyan
Close mozilla-mobile#18443: Use recyclerview-selection for multi-sele…
0abe0f2 
…ct mode in tray

Add multi-select mode to the BrowserTabsAdapter. It has the
functionality to:
 - Enable multi-select mode on long-press.
 - Enable multi-select mode when changed by an external function.
 - Only works for normal tabs (as we currently have it).

Co-authored-by: "codrut.topliceanu" <codrut.topliceanu@softvision.ro>
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 5, 2021
@jonalmeida @pkirakosyan
Issue mozilla-mobile#18443: Fix changes between grid/list viewholders
1f02055
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 5, 2021
@jonalmeida @pkirakosyan
Issue mozilla-mobile#18443: Move viewholders to separate files and pa…
d84eaa5 
…ckage
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@codrut-topliceanu codrut-topliceanu

Labels
E3 Estimation Point: average, 2 - 3 days Feature:SyncTabs Sync tabs Feature:Tabs MR1 Issues that are needed for the MR1 2021 release.
Projects
None yet
Milestone
89
Development

Successfully merging a pull request may close this issue.

Close #18443: Use recyclerview-selection for multi-select mode in tray jonalmeida/fenix
3 participants
@gabrielluong @jonalmeida @codrut-topliceanu