This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Migrate mutli-selection to store #18774

Closed

jonalmeida opened this issue Apr 2, 2021 · 0 comments · Fixed by #18778

Assignees

Labels

E2

Milestone

Contributor

jonalmeida commented Apr 2, 2021 •

edited by data-sync-user

Loading

We tried the recyclerview-selection library and while it worked, it was difficult to use.

We had to keep a track of the selections in order to know when entering/exiting selection mode.
The selection was tied tightly to the RecyclerView - this is obvious in hind sight (🤦 ) but when setting up the selection tracker and retrieving the selected items to be used in parent ViewGroup, we were re-creating a selection storage concept all over again.

This is a problem that's already solved in the "library" by using the SelectionInteractor and SelectionHolder along with lib-state.

In #17821, we added the storer, so let's put our multi-select items in that instead.

┆Issue is synchronized with this Jira Task

The text was updated successfully, but these errors were encountered:

jonalmeida self-assigned this

jonalmeida added the E2 label

github-actions bot added the needs:triage label

jonalmeida added a commit to jonalmeida/fenix that referenced this issue


          Issue mozilla-mobile#18774: Move SelectionInteractor to new package

05f77e0

The interactor and holder are useful outside of the `library` package, so
let's move it up a package level for other components.

jonalmeida added a commit to jonalmeida/fenix that referenced this issue


          Close mozilla-mobile#18774: Migrate mutli-selection to store

8093b8e

Removes the recyclerview-selection library and replaces it with the
SelectionHolder/SelectionInteractor with a Store.

This is an implementation that's similar to what we have in other UI
lists (library).

jonalmeida mentioned this issue

Close #18774: Migrate mutli-selection to store #18778

Merged

3 tasks

jonalmeida added a commit to jonalmeida/fenix that referenced this issue


          Close mozilla-mobile#18774: Migrate mutli-selection to store

ccced43

Removes the recyclerview-selection library and replaces it with the
SelectionHolder/SelectionInteractor with a Store.

This is an implementation that's similar to what we have in other UI
lists (library).

jonalmeida added a commit to jonalmeida/fenix that referenced this issue


          Issue mozilla-mobile#18774: Move SelectionInteractor to new package

d1f8db5

The interactor and holder are useful outside of the `library` package, so
let's move it up a package level for other components.

jonalmeida added a commit to jonalmeida/fenix that referenced this issue


          Close mozilla-mobile#18774: Migrate mutli-selection to store

bb5a0da

Removes the recyclerview-selection library and replaces it with the
SelectionHolder/SelectionInteractor with a Store.

This is an implementation that's similar to what we have in other UI
lists (library).

jonalmeida added a commit to jonalmeida/fenix that referenced this issue


          Issue mozilla-mobile#18774: Move SelectionInteractor to new package

7b144e6

The interactor and holder are useful outside of the `library` package, so
let's move it up a package level for other components.

jonalmeida added a commit to jonalmeida/fenix that referenced this issue


          Close mozilla-mobile#18774: Migrate mutli-selection to store

931f78d

Removes the recyclerview-selection library and replaces it with the
SelectionHolder/SelectionInteractor with a Store.

This is an implementation that's similar to what we have in other UI
lists (library).

jonalmeida added a commit to jonalmeida/fenix that referenced this issue


          Close mozilla-mobile#18774: Migrate mutli-selection to store

e71cd9d

Removes the recyclerview-selection library and replaces it with the
SelectionHolder/SelectionInteractor with a Store.

This is an implementation that's similar to what we have in other UI
lists (library).

jonalmeida added a commit to jonalmeida/fenix that referenced this issue


          Issue mozilla-mobile#18774: Fix long parameter warnings in detekt

e31db0e

jonalmeida added a commit to jonalmeida/fenix that referenced this issue


          Issue mozilla-mobile#18774: Move SelectionInteractor to new package

3ccd62f

The interactor and holder are useful outside of the `library` package, so
let's move it up a package level for other components.

jonalmeida added a commit to jonalmeida/fenix that referenced this issue


          Close mozilla-mobile#18774: Migrate mutli-selection to store

ce929b5

Removes the recyclerview-selection library and replaces it with the
SelectionHolder/SelectionInteractor with a Store.

This is an implementation that's similar to what we have in other UI
lists (library).

jonalmeida added a commit to jonalmeida/fenix that referenced this issue


          Issue mozilla-mobile#18774: Fix long parameter warnings in detekt

ec1833c

jonalmeida closed this as completed in #18778

jonalmeida added a commit that referenced this issue


          Issue #18774: Move SelectionInteractor to new package

499aa85

The interactor and holder are useful outside of the `library` package, so
let's move it up a package level for other components.

jonalmeida added a commit that referenced this issue


          Close #18774: Migrate mutli-selection to store

Removes the recyclerview-selection library and replaces it with the
SelectionHolder/SelectionInteractor with a Store.

This is an implementation that's similar to what we have in other UI
lists (library).

jonalmeida added a commit that referenced this issue


          Issue #18774: Fix long parameter warnings in detekt

09e9561

gabrielluong added this to the 89 milestone

gabrielluong removed the needs:triage label

pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue


          Issue mozilla-mobile#18774: Move SelectionInteractor to new package

29042da

The interactor and holder are useful outside of the `library` package, so
let's move it up a package level for other components.

pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue


          Close mozilla-mobile#18774: Migrate mutli-selection to store

16d4423

pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue


          Issue mozilla-mobile#18774: Fix long parameter warnings in detekt

6d79189

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.