-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Turn off all Leanplum integrations on Fenix by May 31,2021 #19040
Comments
@krupa-raj So I'm clear, do we need to ship this on May 31st or by May 31st? |
I'll look into preparing a PR for making this changes in the 88 release branch. |
Just an FYI: We have default browser campaigns live in iOS release and Fenix Nightly and Release. I can stop the Nightly campaign if need be. I was thinking of stopping campaigns on May 21st, but since we are thinking of an 88 dot release I can stop as you chose a date with Rel Eng, Just slack me once you have a decision. |
@topotropic FYI. Here's the corresponding GH ticket referred in the email with subject: "Removing Leanplum from Fenix / Needs string change in settings" |
We have removed Leanplum from Nightly (string not updated yet). Beta and Release PRs are up, but not ready for landing yet (needs coordination). |
Added the "qa needed" label for Nightly. Overall the patch does not seem risky. The "push" integration needed to change in order to remove Leanplum. So one thing we could explicitly test is that web push is still working correctly. |
Hi @pocmo! We cannot identify new devices that use the latest Nightly build from 4/28. I'll remove the qa:needed label, but leave this issue opened for further testing. |
@lobontiumira Sorry, I realized I didn't make it clear what "push" I was talking about. So, Leanplum is completely removed from Nightly. Not being able to identify new devices from Leanplum and no IDs showing up in the secret settings is expected and good to be verified 👍. The thing that should still work, and previously had code overlap with Leanplum, is web push messages/notifications from websites (e.g. see MDN and Documentation on Web Push Notifications). @jonalmeida recommended the following two pages for testing: |
We need to ship the changes by May 31st. My preference is to not wait until the last minute to do it. Sorry about the late reply. |
Verified on https://gauntface.github.io/simple-push-demo/ with Google Pixel (Android 10), and Samsung Galaxy Note 8 (Android 9) that the web push notifications are still working on the 4/29 Nightly build. Leaving this issue opened for the beta, and RC testing. |
Confirming that web push messages works as expected on 89.0.0-beta.4. |
Landed the removal patch on the 88 release branch too. |
Verified on https://gauntface.github.io/simple-push-demo/ with Samsung Galaxy Note 8 (Android 9) that the web push notifications are working as expected on RC 88.1.4 build. |
Mozilla has decided to not renew our Leanplum contract for 2021-22. The current contract will expire on May 31, 2021. We need to turn off any Leanplum integrations in our products by that date.
This work should include the following:
Currently the Marketing data setting under the Data collection group says
When we remove Leanplum from the product, this toggle will only enable/disable Adjust. That should probably be reflected in the string we use for the Marketing data setting.
@amedyne @rvandermeulen Because of the adjusted 89 schedule, we probably need to ship this change in a 88 update on May 31st.
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: