Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Turn off all Leanplum integrations on Fenix by May 31,2021 #19040

Closed
krupa-raj opened this issue Apr 14, 2021 · 13 comments
Closed

Turn off all Leanplum integrations on Fenix by May 31,2021 #19040

krupa-raj opened this issue Apr 14, 2021 · 13 comments
Assignees
Labels
eng:qa:verified QA Verified needs:UX-feedback Needs UX Feedback performance Possible performance wins
Milestone

Comments

@krupa-raj
Copy link

krupa-raj commented Apr 14, 2021

Mozilla has decided to not renew our Leanplum contract for 2021-22. The current contract will expire on May 31, 2021. We need to turn off any Leanplum integrations in our products by that date.

This work should include the following:

  • Remove the Leanplum SDK dependency from our builds so that the product does not include it anymore.
  • Remove all Leanplum related code from the product
  • Remove all Leanplum related UI from the product

Currently the Marketing data setting under the Data collection group says

Shares data about what features you use in Firefox with Leanplum, our mobile marketing vendor.

When we remove Leanplum from the product, this toggle will only enable/disable Adjust. That should probably be reflected in the string we use for the Marketing data setting.

@amedyne @rvandermeulen Because of the adjusted 89 schedule, we probably need to ship this change in a 88 update on May 31st.

┆Issue is synchronized with this Jira Task

@github-actions github-actions bot added the needs:triage Issue needs triage label Apr 14, 2021
@rvandermeulen
Copy link
Contributor

rvandermeulen commented Apr 20, 2021

Turn off all Leanplum integrations on Fenix by May 31,2021

Because of the adjusted 89 schedule, we probably need to ship this change in a 88 update on May 31st.

@krupa-raj So I'm clear, do we need to ship this on May 31st or by May 31st?

@pocmo pocmo self-assigned this Apr 21, 2021
@pocmo
Copy link
Contributor

pocmo commented Apr 21, 2021

I'll look into preparing a PR for making this changes in the 88 release branch.

@ItsDevyani
Copy link

Just an FYI: We have default browser campaigns live in iOS release and Fenix Nightly and Release. I can stop the Nightly campaign if need be. I was thinking of stopping campaigns on May 21st, but since we are thinking of an 88 dot release I can stop as you chose a date with Rel Eng, Just slack me once you have a decision.

pocmo added a commit to pocmo/fenix that referenced this issue Apr 22, 2021
@amedyne
Copy link
Contributor

amedyne commented Apr 22, 2021

@topotropic FYI. Here's the corresponding GH ticket referred in the email with subject: "Removing Leanplum from Fenix / Needs string change in settings"

@amedyne amedyne added needs:UX-feedback Needs UX Feedback and removed needs:triage Issue needs triage labels Apr 22, 2021
pocmo added a commit to pocmo/fenix that referenced this issue Apr 26, 2021
pocmo added a commit to pocmo/fenix that referenced this issue Apr 26, 2021
pocmo added a commit to pocmo/fenix that referenced this issue Apr 26, 2021
pocmo added a commit that referenced this issue Apr 26, 2021
@mcomella mcomella added the performance Possible performance wins label Apr 26, 2021
@pocmo
Copy link
Contributor

pocmo commented Apr 27, 2021

We have removed Leanplum from Nightly (string not updated yet). Beta and Release PRs are up, but not ready for landing yet (needs coordination).

@pocmo pocmo added the eng:qa:needed QA Needed label Apr 27, 2021
@pocmo
Copy link
Contributor

pocmo commented Apr 27, 2021

Added the "qa needed" label for Nightly. Overall the patch does not seem risky. The "push" integration needed to change in order to remove Leanplum. So one thing we could explicitly test is that web push is still working correctly.

@lobontiumira
Copy link

Hi @pocmo!

We cannot identify new devices that use the latest Nightly build from 4/28.
We've also tried to send a push notification to a test device that was registered previously and bumped into this error "No push token exist for this device".
notoken
This is most likely due to the fact that "Firefox news" has been removed...

I'll remove the qa:needed label, but leave this issue opened for further testing.

@lobontiumira lobontiumira added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Apr 28, 2021
@pocmo
Copy link
Contributor

pocmo commented Apr 28, 2021

@lobontiumira Sorry, I realized I didn't make it clear what "push" I was talking about. So, Leanplum is completely removed from Nightly. Not being able to identify new devices from Leanplum and no IDs showing up in the secret settings is expected and good to be verified 👍. The thing that should still work, and previously had code overlap with Leanplum, is web push messages/notifications from websites (e.g. see MDN and Documentation on Web Push Notifications). @jonalmeida recommended the following two pages for testing:

@krupa-raj
Copy link
Author

ns on Fenix by May 31,2021

Because of the adjusted 89 schedule, we probably need to ship this change in a 88 update on May 31st.

We need to ship the changes by May 31st. My preference is to not wait until the last minute to do it. Sorry about the late reply.

@lobontiumira
Copy link

Verified on https://gauntface.github.io/simple-push-demo/ with Google Pixel (Android 10), and Samsung Galaxy Note 8 (Android 9) that the web push notifications are still working on the 4/29 Nightly build.

Leaving this issue opened for the beta, and RC testing.

@sflorean
Copy link
Contributor

sflorean commented May 4, 2021

Confirming that web push messages works as expected on 89.0.0-beta.4.

@pocmo
Copy link
Contributor

pocmo commented May 17, 2021

Landed the removal patch on the 88 release branch too.

@lobontiumira
Copy link

Verified on https://gauntface.github.io/simple-push-demo/ with Samsung Galaxy Note 8 (Android 9) that the web push notifications are working as expected on RC 88.1.4 build.
I'll close this issue since all the builds were verified.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:qa:verified QA Verified needs:UX-feedback Needs UX Feedback performance Possible performance wins
Projects
None yet
Development

No branches or pull requests

9 participants